Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C5EDB10D1C for ; Mon, 12 Aug 2013 13:07:38 +0000 (UTC) Received: (qmail 26411 invoked by uid 500); 12 Aug 2013 13:07:35 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 26182 invoked by uid 500); 12 Aug 2013 13:07:34 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 26171 invoked by uid 99); 12 Aug 2013 13:07:34 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Aug 2013 13:07:34 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C87FA1D27B8; Mon, 12 Aug 2013 13:07:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8015963389561816079==" MIME-Version: 1.0 Subject: Re: Review Request 13495: CLOUDSTACK-4189: [UI] In multi zone setup, dedicating a single zone to a domain, shows other zones dedicated as well From: "ASF Subversion and Git Services" To: "Devdeep Singh" Cc: "Saksham Srivastava" , "ASF Subversion and Git Services" , "cloudstack" Date: Mon, 12 Aug 2013 13:07:33 -0000 Message-ID: <20130812130733.5632.40710@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "ASF Subversion and Git Services" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/13495/ X-Sender: "ASF Subversion and Git Services" References: <20130812122803.5632.32856@reviews.apache.org> In-Reply-To: <20130812122803.5632.32856@reviews.apache.org> Reply-To: "ASF Subversion and Git Services" --===============8015963389561816079== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13495/#review24997 ----------------------------------------------------------- Commit 5510bca9e5223730dc469b443b50d26550533360 in branch refs/heads/master from Saksham Srivastava [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5510bca ] CLOUDSTACK-4189: [UI] In multi zone setup, dedicating a single zone to a domain, shows other zones dedicated as well - ASF Subversion and Git Services On Aug. 12, 2013, 12:28 p.m., Saksham Srivastava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13495/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2013, 12:28 p.m.) > > > Review request for cloudstack and Devdeep Singh. > > > Bugs: CLOUDSTACK-4189 > > > Repository: cloudstack-git > > > Description > ------- > > Listing out dedicated zones with zone id is returning all dedicated zones. > Issue: search criteria was always passing null for the zoneid. > Fixed the issue by setting zoneId inplace of datacenter id. > > > Diffs > ----- > > server/src/com/cloud/dc/dao/DedicatedResourceDaoImpl.java 6c91ce7 > > Diff: https://reviews.apache.org/r/13495/diff/ > > > Testing > ------- > > list dedicatedzone with zoneid now returns correct dedicated zone. > > > Thanks, > > Saksham Srivastava > > --===============8015963389561816079==--