Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 75D0610767 for ; Mon, 12 Aug 2013 09:00:06 +0000 (UTC) Received: (qmail 71237 invoked by uid 500); 12 Aug 2013 09:00:04 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 71101 invoked by uid 500); 12 Aug 2013 09:00:02 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 71049 invoked by uid 99); 12 Aug 2013 09:00:00 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Aug 2013 09:00:00 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id ADB091C9A50; Mon, 12 Aug 2013 08:59:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8064403562734869945==" MIME-Version: 1.0 Subject: Re: Review Request 13491: Fix specifying db passwd in cloud-install-sys-tmplt From: "Hugo Trippaers" To: "Dave Cahill" , "Hugo Trippaers" , "cloudstack" Date: Mon, 12 Aug 2013 08:59:59 -0000 Message-ID: <20130812085959.5632.74583@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Hugo Trippaers" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/13491/ X-Sender: "Hugo Trippaers" References: <20130812071417.5660.57325@reviews.apache.org> In-Reply-To: <20130812071417.5660.57325@reviews.apache.org> Reply-To: "Hugo Trippaers" --===============8064403562734869945== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13491/#review24987 ----------------------------------------------------------- Ship it! Ship It! - Hugo Trippaers On Aug. 12, 2013, 7:14 a.m., Dave Cahill wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13491/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2013, 7:14 a.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > Previously database password was specified as a no-argument option, however the rest of the script expected an argument. > > > Diffs > ----- > > scripts/storage/secondary/cloud-install-sys-tmplt 7237ffa840878e3ce31e71964430fba38f93efb2 > > Diff: https://reviews.apache.org/r/13491/diff/ > > > Testing > ------- > > Tested installing System VM template using the script and specifying db username / pass before change (didn't work) and after (worked). > > > Thanks, > > Dave Cahill > > --===============8064403562734869945==--