Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 893D510927 for ; Sat, 10 Aug 2013 11:36:15 +0000 (UTC) Received: (qmail 83028 invoked by uid 500); 10 Aug 2013 11:36:14 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 82855 invoked by uid 500); 10 Aug 2013 11:36:14 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 82843 invoked by uid 99); 10 Aug 2013 11:36:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 Aug 2013 11:36:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B811E1C0888; Sat, 10 Aug 2013 11:36:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3633549898595110244==" MIME-Version: 1.0 Subject: Review Request 13469: CLOUDSTACK-3946 [KVM] [Zone Wide Primary Storages] migrateVolume is deleting the volume if the source and destination pool are same. From: "Rajesh Battala" To: "Ram Ganesh" , "edison su" , "Devdeep Singh" Cc: "Rajesh Battala" , "cloudstack" Date: Sat, 10 Aug 2013 11:36:12 -0000 Message-ID: <20130810113612.1163.6492@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Rajesh Battala" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/13469/ X-Sender: "Rajesh Battala" Reply-To: "Rajesh Battala" --===============3633549898595110244== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13469/ ----------------------------------------------------------- Review request for cloudstack, Devdeep Singh, edison su, and Ram Ganesh. Bugs: CLOUDSTACK-3946 Repository: cloudstack-git Description ------- while migrating volume, if the storage and destination pool are same, we are still do overhead of copying the volume to same pool and deleting the other src copy. fixed the issue by restricting volumemigration if the source and destination pool are same. Diffs ----- server/src/com/cloud/storage/VolumeManagerImpl.java 100aad3 Diff: https://reviews.apache.org/r/13469/diff/ Testing ------- 1. Successfully migrated the volume from Storagepool A to pool B. 2. migration is not allowed if the source and destination are same. 3. tried the volume with storage pool scope (ZONE and Cluster) Thanks, Rajesh Battala --===============3633549898595110244==--