Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6CFEC10E2F for ; Wed, 7 Aug 2013 01:45:18 +0000 (UTC) Received: (qmail 48433 invoked by uid 500); 7 Aug 2013 01:45:18 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 48396 invoked by uid 500); 7 Aug 2013 01:45:18 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 48387 invoked by uid 500); 7 Aug 2013 01:45:17 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 48379 invoked by uid 99); 7 Aug 2013 01:45:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Aug 2013 01:45:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 15E7B1D2517; Wed, 7 Aug 2013 01:45:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0541478768241053134==" MIME-Version: 1.0 Subject: Re: Review Request 12849: added backwards compatibility code to Networks enums From: "Sheng Yang" To: "Koushik Das" , "Dave Cahill" , "Chiradeep Vittal" , "Sheng Yang" Cc: "daan Hoogland" , "cloudstack" , "Toshiaki Hatano" Date: Wed, 07 Aug 2013 01:45:16 -0000 Message-ID: <20130807014516.17556.99157@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Sheng Yang" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/12849/ X-Sender: "Sheng Yang" References: <20130806234002.17559.75574@reviews.apache.org> In-Reply-To: <20130806234002.17559.75574@reviews.apache.org> Reply-To: "Sheng Yang" --===============0541478768241053134== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Aug. 6, 2013, 11:40 p.m., Sheng Yang wrote: > > api/src/com/cloud/network/Networks.java, line 135 > > > > > > I think by following the previous case, it should be URI(scheme,value.toString()) rather than "null, null". It possibly doesn't make difference, but it's better not to use different constructor. > > > > The same with several URI constructor above. > > > > And I doubt if it's really need to discard this check. At least they would working for other broadcast domain type. Dave explained this. Please drop this issue. - Sheng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/#review24756 ----------------------------------------------------------- On Aug. 6, 2013, 2:25 p.m., daan Hoogland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12849/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2013, 2:25 p.m.) > > > Review request for cloudstack, Chiradeep Vittal, Dave Cahill, Koushik Das, and Sheng Yang. > > > Repository: cloudstack-git > > > Description > ------- > > Both BroadcastDomainType and IsolationType needed some extra code for backwards compatibility > > > Diffs > ----- > > api/src/com/cloud/network/Networks.java c76c3d4 > api/test/com/cloud/network/NetworksTest.java 31114e8 > > Diff: https://reviews.apache.org/r/12849/diff/ > > > Testing > ------- > > > Thanks, > > daan Hoogland > > --===============0541478768241053134==--