Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AE13510A9E for ; Mon, 5 Aug 2013 18:22:02 +0000 (UTC) Received: (qmail 25334 invoked by uid 500); 5 Aug 2013 18:22:02 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 25304 invoked by uid 500); 5 Aug 2013 18:22:02 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 25296 invoked by uid 500); 5 Aug 2013 18:22:01 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 25290 invoked by uid 99); 5 Aug 2013 18:22:01 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Aug 2013 18:22:01 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2289E1D1E4E; Mon, 5 Aug 2013 18:22:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1782458972504893193==" MIME-Version: 1.0 Subject: Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool From: "edison su" To: "Wido den Hollander" , "edison su" Cc: "cloudstack" , "Wei Zhou" Date: Mon, 05 Aug 2013 18:22:00 -0000 Message-ID: <20130805182200.5384.83502@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "edison su" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/13223/ X-Sender: "edison su" References: <20130805180737.5391.73403@reviews.apache.org> In-Reply-To: <20130805180737.5391.73403@reviews.apache.org> Reply-To: "edison su" --===============1782458972504893193== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13223/#review24657 ----------------------------------------------------------- Ship it! Ship It! - edison su On Aug. 5, 2013, 6:07 p.m., Wei Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13223/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2013, 6:07 p.m.) > > > Review request for cloudstack, edison su and Wido den Hollander. > > > Bugs: CLOUDSTACK-2729 > > > Repository: cloudstack-git > > > Description > ------- > > The storage pool issue (CLOUDSTACK-2729) is because of a bug in libvirt (https://bugzilla.redhat.com/show_bug.cgi?id=977706) > We need to prevent deleting a volume when refreshing the pool. > This patch use a simple file lock to implement it. > > PS: I have tested another file lock similar to Read/Write file lock, but it was very unstable. > > > Diffs > ----- > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java b8a9f0f > > Diff: https://reviews.apache.org/r/13223/diff/ > > > Testing > ------- > > Applied on 4.0.2 and 4.0.1 > > Testing On 4.0.1 From 20,June > 3 nodes, create a VM on each node every 15 minutes. Destroy the VMs 5 minutes later. expunge.inteval = 600 (10 minutes), expunge.worker = 2 > > > Testing On 4.0.2 From 01,July > 2 nodes, create two VMs on each node every 5 minutes. Destroy the VMs 4 minutes later. expunge.inteval = 600 (10 minutes), expunge.worker = 2 > > > Thanks, > > Wei Zhou > > --===============1782458972504893193==--