cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Musayev, Ilya" <imusa...@webmd.net>
Subject RE: [DISCUSS] git commit messages
Date Fri, 16 Aug 2013 16:09:18 GMT
+1, this should be really easy to add and helps tremendously and troubleshooting!

> -----Original Message-----
> From: Koushik Das [mailto:koushik.das@citrix.com]
> Sent: Friday, August 16, 2013 1:48 AM
> To: dev@cloudstack.apache.org
> Subject: RE: [DISCUSS] git commit messages
> 
> Agree. The message should indicate the root cause of the problem and the
> solution.
> 
> -Koushik
> 
> > -----Original Message-----
> > From: Alex Huang [mailto:Alex.Huang@citrix.com]
> > Sent: Friday, August 16, 2013 2:58 AM
> > To: dev@cloudstack.apache.org
> > Subject: RE: [DISCUSS] git commit messages
> >
> > +1
> >
> > --Alex
> >
> > > -----Original Message-----
> > > From: Daan Hoogland [mailto:daan.hoogland@gmail.com]
> > > Sent: Thursday, August 15, 2013 11:58 AM
> > > To: dev
> > > Subject: Re: [DISCUSS] git commit messages
> > >
> > > ok,
> > >
> > > I saw some violation passing by containing only
> > > CLOUDSTACK-<ticket-number> as message.
> > >
> > > I am probably not the best citizen in the world but this freaks me,
> > > so this is a reminder to everyone to add a message (and for
> > > committers to refuse submissions without it?)
> > >
> > > thanks,
> > > Daan
> > >
> > > On Thu, Aug 15, 2013 at 8:49 PM, Animesh Chaturvedi
> > > <animesh.chaturvedi@citrix.com> wrote:
> > > > Yes the commit message should have a brief summary of the change
> > > >
> > > >> -----Original Message-----
> > > >> From: Chiradeep Vittal [mailto:Chiradeep.Vittal@citrix.com]
> > > >> Sent: Thursday, August 15, 2013 11:36 AM
> > > >> To: dev@cloudstack.apache.org
> > > >> Subject: Re: [DISCUSS] git commit messages
> > > >>
> > > >> Not good. Especially since it is documented
> > > >> https://cwiki.apache.org/confluence/x/4wnVAQ
> > > >>
> > > >> On 8/13/13 1:41 AM, "Daan Hoogland" <daan.hoogland@gmail.com>
> > > wrote:
> > > >>
> > > >> >LS,
> > > >> >
> > > >> >I see a lot of commits with only ticket  numbers as commit messages.
> > > >> >This is not very descriptive and makes me suspicious of what I
> > > >> >am pulling in. Can people please append a more descriptive
> > > >> >message to the ticket number? Or am I the only one disturbed by
> this?
> > > >> >
> > > >> >regards,
> > > >> >Daan
> > > >



Mime
View raw message