cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Animesh Chaturvedi <animesh.chaturv...@citrix.com>
Subject RE: Review Request 11942: ProcessUtil cleanup
Date Tue, 13 Aug 2013 00:55:47 GMT
ProcessUtilTest is missing Apache License Header and failing rat-test

> -----Original Message-----
> From: Animesh Chaturvedi [mailto:animesh.chaturvedi@citrix.com]
> Sent: Monday, August 12, 2013 5:40 PM
> To: Frank Zhang; dev@cloudstack.apache.org; John Burwell
> Cc: Laszlo Hornyak
> Subject: RE: Review Request 11942: ProcessUtil cleanup
> 
> We should keep it for master
> 
> > -----Original Message-----
> > From: Frank Zhang
> > Sent: Monday, August 12, 2013 5:40 PM
> > To: Animesh Chaturvedi; dev@cloudstack.apache.org; John Burwell
> > Cc: Laszlo Hornyak
> > Subject: RE: Review Request 11942: ProcessUtil cleanup
> >
> > Emm. Actually it's not a blocker or even critical for 4.2.
> > Though I thought it's not harm, if needs I can revert it from 4.2 but
> > still keep it in master.
> >
> > > -----Original Message-----
> > > From: Animesh Chaturvedi
> > > Sent: Monday, August 12, 2013 5:37 PM
> > > To: dev@cloudstack.apache.org; Frank Zhang; John Burwell
> > > Cc: Laszlo Hornyak
> > > Subject: RE: Review Request 11942: ProcessUtil cleanup
> > >
> > > Is this really needed for 4.2? 4.2 is in limited updates and only
> > > blocker/critical bug fixes and doc and test updates are allowed. All
> > > commits to 4.2 should have associated BUG id.
> > >
> > > > -----Original Message-----
> > > > From: Frank Zhang [mailto:noreply@reviews.apache.org] On Behalf Of
> > > > Frank Zhang
> > > > Sent: Monday, August 12, 2013 2:43 PM
> > > > To: John Burwell; Frank Zhang
> > > > Cc: Laszlo Hornyak; cloudstack
> > > > Subject: Re: Review Request 11942: ProcessUtil cleanup
> > > >
> > > >
> > > > -----------------------------------------------------------
> > > > This is an automatically generated e-mail. To reply, visit:
> > > > https://reviews.apache.org/r/11942/#review25036
> > > > -----------------------------------------------------------
> > > >
> > > > Ship it!
> > > >
> > > >
> > > > This is very straightforward patch. Java filesystem api is known
> > > > as unnecessary complex, we should take advantage of Apache
> > > > common-io as much as possible.
> > > > shipped in 4.2 and master
> > > >
> > > > - Frank Zhang
> > > >
> > > >
> > > > On July 24, 2013, 4:42 a.m., Laszlo Hornyak wrote:
> > > > >
> > > > > -----------------------------------------------------------
> > > > > This is an automatically generated e-mail. To reply, visit:
> > > > > https://reviews.apache.org/r/11942/
> > > > > -----------------------------------------------------------
> > > > >
> > > > > (Updated July 24, 2013, 4:42 a.m.)
> > > > >
> > > > >
> > > > > Review request for cloudstack, Frank Zhang and John Burwell.
> > > > >
> > > > >
> > > > > Repository: cloudstack-git
> > > > >
> > > > >
> > > > > Description
> > > > > -------
> > > > >
> > > > > - possible resource leak closed
> > > > > - file content read uses now commons-lang FileUtils
> > > > > - Added unit tests
> > > > >
> > > > >
> > > > > Diffs
> > > > > -----
> > > > >
> > > > >   utils/src/com/cloud/utils/ProcessUtil.java c9fdf35
> > > > >   utils/test/com/cloud/utils/ProcessUtilTest.java PRE-CREATION
> > > > >
> > > > > Diff: https://reviews.apache.org/r/11942/diff/
> > > > >
> > > > >
> > > > > Testing
> > > > > -------
> > > > >
> > > > > test included
> > > > >
> > > > >
> > > > > Thanks,
> > > > >
> > > > > Laszlo Hornyak
> > > > >
> > > > >

Mime
View raw message