cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Saksham Srivastava <saksham.srivast...@citrix.com>
Subject RE: Reverting 17267794adb2bab923fb20515a7b943780d61921
Date Mon, 05 Aug 2013 11:26:48 GMT
+1, Although I did not add/edit/remove any sql statements in this file, it was a blank line
that got removed in my patch.
Enforcing it would prevent such slips to happen.

Saksham

-----Original Message-----
From: Koushik Das 
Sent: Monday, August 05, 2013 12:49 PM
To: dev@cloudstack.apache.org; Saksham Srivastava
Subject: RE: Reverting 17267794adb2bab923fb20515a7b943780d61921

+1. Provided git allows to make a specific file as read-only.

> -----Original Message-----
> From: Nitin Mehta [mailto:Nitin.Mehta@citrix.com]
> Sent: Monday, August 05, 2013 12:01 PM
> To: dev@cloudstack.apache.org; Saksham Srivastava
> Subject: Re: Reverting 17267794adb2bab923fb20515a7b943780d61921
> 
> Should we not try and enforce it through git ?
> 
> On 02/08/13 10:44 PM, "Alex Huang" <Alex.Huang@citrix.com> wrote:
> 
> >Ok...i spoke too soon.  Just talked with Prasanna.  He pointed out 
> >that it's a large change that's been in since May.  So I won't revert it.
> >But the rule is no one can change create-schema.sql until the 
> >community decided we want to based off of a new copy of the create-schema.
> >
> >--Alex
> >
> >> -----Original Message-----
> >> From: Alex Huang [mailto:Alex.Huang@citrix.com]
> >> Sent: Friday, August 2, 2013 10:01 AM
> >> To: Saksham Srivastava
> >> Cc: dev@cloudstack.apache.org
> >> Subject: Reverting 17267794adb2bab923fb20515a7b943780d61921
> >>
> >> Saksham,
> >>
> >> I'm reverting commit id: 17267794adb2bab923fb20515a7b943780d61921 
> >> in master.
> >>
> >> It changed the create-schema.sql.  We've established since 4.1 that
> >>create-
> >> schema.sql should not be changed and everything done through
> upgrades.
> >>I
> >> believe this commit causes a fresh deployment to fail.
> >>
> >> --Alex


Mime
View raw message