cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Burwell <jburw...@basho.com>
Subject Re: Review Request 11942: ProcessUtil cleanup
Date Mon, 12 Aug 2013 21:45:34 GMT
Laszlo,

I was only concerned about the lack of asserts in the original test case.  That has been updated,
so it looks good to me now.

Thanks,
-John

On Aug 12, 2013, at 5:43 PM, "Frank Zhang" <frank.zhang@citrix.com> wrote:

> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11942/#review25036
> -----------------------------------------------------------
> 
> Ship it!
> 
> 
> This is very straightforward patch. Java filesystem api is known as unnecessary complex,
we should take advantage of Apache common-io as much as possible.
> shipped in 4.2 and master
> 
> - Frank Zhang
> 
> 
> On July 24, 2013, 4:42 a.m., Laszlo Hornyak wrote:
>> 
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/11942/
>> -----------------------------------------------------------
>> 
>> (Updated July 24, 2013, 4:42 a.m.)
>> 
>> 
>> Review request for cloudstack, Frank Zhang and John Burwell.
>> 
>> 
>> Repository: cloudstack-git
>> 
>> 
>> Description
>> -------
>> 
>> - possible resource leak closed
>> - file content read uses now commons-lang FileUtils
>> - Added unit tests
>> 
>> 
>> Diffs
>> -----
>> 
>>  utils/src/com/cloud/utils/ProcessUtil.java c9fdf35 
>>  utils/test/com/cloud/utils/ProcessUtilTest.java PRE-CREATION 
>> 
>> Diff: https://reviews.apache.org/r/11942/diff/
>> 
>> 
>> Testing
>> -------
>> 
>> test included
>> 
>> 
>> Thanks,
>> 
>> Laszlo Hornyak
>> 
>> 
> 


Mime
View raw message