cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request 13911: CLOUDSTACK-4572: findHostsForMigration API does not return correct host list
Date Fri, 30 Aug 2013 19:46:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13911/#review25801
-----------------------------------------------------------


Commit 6354604eedff0c5f4ddef4940ce02df80adb656c in branch refs/heads/4.2-forward from Saksham
Srivastava
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6354604 ]

CLOUDSTACK-4572: findHostsForMigration API does not return correct host list

Changes:
Expected behavior:
The api should return the list of suitable/unsuitable hosts
Added fix that creates a deep copy of the the variable allHosts and prevents faulty host list
return.


- ASF Subversion and Git Services


On Aug. 30, 2013, 4:38 p.m., Saksham Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13911/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2013, 4:38 p.m.)
> 
> 
> Review request for cloudstack and Devdeep Singh.
> 
> 
> Bugs: CLOUDSTACK-4572
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Create multi cluster setup. 
> Tag host in one cluster with host tag t1. 
> Create a service offering using the host tag t1 
> Deploy a vm using the tagged service offering. 
> Even if tagged/untagged hosts are available across different clusters the api does not
list correct hosts for migration for the deployed vm. 
> 
> Expected behavior: 
> The api should return the list of suitable/unsuitable hosts
> 
> Added fix that creates a deep copy of the the variable allHosts and prevents faulty host
list return.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/server/ManagementServerImpl.java 3341c05 
> 
> Diff: https://reviews.apache.org/r/13911/diff/
> 
> 
> Testing
> -------
> 
> UI/API displays the correct host list now.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message