cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request 10957: (CLOUDSTACK-2319) fix "unable to add egress rules" in SecurityGroup
Date Fri, 30 Aug 2013 09:17:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10957/#review25789
-----------------------------------------------------------


Commit d9ba234d6c032aeb2ba04d4e6be0502de8a4efd9 in branch refs/heads/4.2-forward from Wei
Zhou
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d9ba234 ]

CLOUDSTACK-2319: fix incorrect account_id in event table for Revoke SecurityGroupRule commands


- ASF Subversion and Git Services


On May 6, 2013, 6:44 p.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10957/
> -----------------------------------------------------------
> 
> (Updated May 6, 2013, 6:44 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-2319
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> This patch changes:
> (1) CloudStack UI (egress rule in Security Group)
> (2) findByUuidIncludingRemoved(uuid) return security_group_rule.id (find by security_group_rule.uuid)
instead of security_group.id (find by security_group.uuid)
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/network/security/SecurityGroupRules.java d255e46 
>   core/src/com/cloud/network/security/SecurityGroupRulesVO.java 82060ef 
>   server/src/com/cloud/network/security/dao/SecurityGroupRulesDaoImpl.java f08ca05 
>   ui/scripts/network.js 1bc4eba 
> 
> Diff: https://reviews.apache.org/r/10957/diff/
> 
> 
> Testing
> -------
> 
> Testing ok.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message