cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "bharat kumar" <bharat.ku...@citrix.com>
Subject Re: Review Request 13807: we should not reserve memory and cpu for vmware VMs if the vmware.reserve.cpu and vmware.reserve.mem are set to false.
Date Tue, 27 Aug 2013 13:52:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13807/
-----------------------------------------------------------

(Updated Aug. 27, 2013, 1:52 p.m.)


Review request for cloudstack and Nitin Mehta.


Changes
-------

rebased with 4.2-forward


Bugs: Cloudstack-4498


Repository: cloudstack-git


Description
-------

https://issues.apache.org/jira/browse/CLOUDSTACK-4498
we should not reserve memory and cpu for vmware VMs if the vmware.reserve.cpu and vmware.reserve.mem
are set to false.

currently overcommit dose not honor the flag vmware.reserve.mem and vmware.reserve.cpu. Now
we have fixed this and brought down these parameters to cluster level.


Diffs (updated)
-----

  plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 8aae8c8 
  plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
4d24562 
  plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
b612ac7 
  server/src/com/cloud/configuration/Config.java 1cc31b6 

Diff: https://reviews.apache.org/r/13807/diff/


Testing
-------

Tested on 4.2


Thanks,

bharat kumar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message