cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Girish Shilamkar" <gir...@clogeny.com>
Subject Re: Review Request 13806: CLOUDSTACK-4407: Use extractTemplate API to get hypervisor specific template information
Date Tue, 27 Aug 2013 08:20:40 GMT


> On Aug. 27, 2013, 5:33 a.m., Prasanna Santhanam wrote:
> > tools/marvin/marvin/integration/lib/base.py, line 891
> > <https://reviews.apache.org/r/13806/diff/1/?file=344716#file344716line891>
> >
> >     extract works on an existing Image/Template. Why should it be a classmethod?
> >     
> >

list_template does not return template object, it returns json loader object. Therefore I
had to define it a classmethod.


- Girish


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13806/#review25551
-----------------------------------------------------------


On Aug. 26, 2013, 1:05 p.m., Girish Shilamkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13806/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2013, 1:05 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-4407
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Template url, hypervisor and format were defined in Service class to be Xenserver specific
>     and therefore registering a new template failed on Vmware and KVM.
>     Fixed this to get hypervisor specific info for registering new template.
> 
> TODO: Update other tests to use the new function get_builtin_template_info
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_templates.py e4599d4 
>   tools/marvin/marvin/integration/lib/base.py b5d086b 
>   tools/marvin/marvin/integration/lib/common.py 4f5acef 
> 
> Diff: https://reviews.apache.org/r/13806/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message