cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasanna Santhanam" <...@apache.org>
Subject Re: Review Request 13806: CLOUDSTACK-4407: Use extractTemplate API to get hypervisor specific template information
Date Tue, 27 Aug 2013 05:33:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13806/#review25551
-----------------------------------------------------------



tools/marvin/marvin/integration/lib/base.py
<https://reviews.apache.org/r/13806/#comment50015>

    extract works on an existing Image/Template. Why should it be a classmethod?
    
    



tools/marvin/marvin/integration/lib/common.py
<https://reviews.apache.org/r/13806/#comment50018>

    What is the purpose of account/domainid? since all accounts have access to the default
builtin?
    
    Also you cannot use the templatefilter=all if the apiclient is that of a non-admin user.
Try 'featured'/'public'



tools/marvin/marvin/integration/lib/common.py
<https://reviews.apache.org/r/13806/#comment50016>

    Please add a help/ docstring 



tools/marvin/marvin/integration/lib/common.py
<https://reviews.apache.org/r/13806/#comment50017>

    Please use Template.list. The list_templates (form of) method is redundant and should
be deprecated. Also check that your template is extractable else raise an Exception.


- Prasanna Santhanam


On Aug. 26, 2013, 1:05 p.m., Girish Shilamkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13806/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2013, 1:05 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-4407
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Template url, hypervisor and format were defined in Service class to be Xenserver specific
>     and therefore registering a new template failed on Vmware and KVM.
>     Fixed this to get hypervisor specific info for registering new template.
> 
> TODO: Update other tests to use the new function get_builtin_template_info
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_templates.py e4599d4 
>   tools/marvin/marvin/integration/lib/base.py b5d086b 
>   tools/marvin/marvin/integration/lib/common.py 4f5acef 
> 
> Diff: https://reviews.apache.org/r/13806/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message