cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gaurav Aradhye" <gaurav.arad...@clogeny.com>
Subject Re: Review Request 13736: Resolved Cloudstack: 4452 - fixed test cases in test_snapshots.py
Date Fri, 23 Aug 2013 10:03:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13736/
-----------------------------------------------------------

(Updated Aug. 23, 2013, 10:03 a.m.)


Review request for cloudstack and Prasanna Santhanam.


Changes
-------

Updated the patch. Added the function to utility and made respective changes in all snapshot
related test suites


Repository: cloudstack-git


Description
-------

Resolved cloudstack: 4452
Changes in function is_snapshot_on_nfs to check if the snapshot is present in the secondary
storage.

Earlier it was trying to match the name of the snapshot present on the storage with the UUID
of the snapshot which is incorrect way.
There's apparently no relation between the snapshot name on the storage and the UUID of the
snapshot.

Changed the function to check if the snapshotPath is valid and is indeed a "File".

Also removed the VM creation (virtual_machine_without_disk) step in setupClass of class TestSnapshots.
It is not used anywhere and was eating up the running time of test case and resources.


Diffs (updated)
-----

  test/integration/component/test_snapshot_gc.py 3cd4194 
  test/integration/component/test_snapshot_limits.py 1bc2798 
  test/integration/component/test_snapshots.py cc2e604 
  tools/marvin/marvin/integration/lib/utils.py 7863bfb 

Diff: https://reviews.apache.org/r/13736/diff/


Testing
-------


Thanks,

Gaurav Aradhye


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message