cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request 13627: Fix for CLOUDSTACK-3441
Date Wed, 21 Aug 2013 09:56:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13627/#review25366
-----------------------------------------------------------


Commit 502c1db1030cfa01850127ba8a8e5e7b1eaf8ead in branch refs/heads/master from Koushik Das
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=502c1db ]

CLOUDSTACK-3441: [Load Test] High delays between VM being allocated to Pod and network implementation
causing delays in VM deployment
The locking code in implement/shutdown network code was not efficient. Even in order to check
the current state of the network lock was getting acquired which is not required. This resulted
in delays in deploy VM as can be seen from attached logs where the code waited on the lock
just to check if network is implemented.
As part of the fix moved out code that is checking if the network is already implemented or
shutdowned outside the lock.


- ASF Subversion and Git Services


On Aug. 17, 2013, 9:32 a.m., Koushik Das wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13627/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2013, 9:32 a.m.)
> 
> 
> Review request for cloudstack, Alex Huang, Abhinandan Prateek, Chiradeep Vittal, and
Murali Reddy.
> 
> 
> Bugs: CLOUDSTACK-3441
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-3441: [Load Test] High delays between VM being allocated to Pod and network
implementation causing delays in VM deployment
> 
> The locking code in implement/shutdown network code was not efficient. Even in order
to check the current state of the network lock was getting acquired which is not required.
This resulted in delays in deploy VM as can be seen from attached logs where the code waited
on the lock just to check if network is implemented.
> 
> As part of the fix moved out code that is checking if the network is already implemented
or shutdowned outside the lock.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/network/NetworkManagerImpl.java 68b1b4f 
> 
> Diff: https://reviews.apache.org/r/13627/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Koushik Das
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message