cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sanjay Tripathi" <sanjay.tripa...@citrix.com>
Subject Re: Review Request 13001: Automation: Adding test cases for CPU limits from Limit Resources.
Date Mon, 19 Aug 2013 11:49:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13001/#review25292
-----------------------------------------------------------



test/integration/component/cpu_limits/test_cpu_limits.py
<https://reviews.apache.org/r/13001/#comment49631>

    can't we have expected_resource_count which would be the exact expected value after the
vm_delete operation and as we already knows about the service offering, we can easily calculate
the expected value.



test/integration/component/cpu_limits/test_cpu_limits.py
<https://reviews.apache.org/r/13001/#comment49632>

    As the test title says "reboot_instance" , please use reboot instance API instead of stopping
and then starting an instance.



test/integration/component/cpu_limits/test_cpu_limits.py
<https://reviews.apache.org/r/13001/#comment49634>

    create and use the expected_resource_count and assign the exact expected value.



test/integration/component/cpu_limits/test_cpu_limits.py
<https://reviews.apache.org/r/13001/#comment49635>

    This seems like a duplicate test as there is already a test which is testing this scenario
i.e. "test_02_migrate_instance"
    
    Please remove the tests which you think are checking the same scenario more than once,
as it will minimize the running time for this script.



test/integration/component/cpu_limits/test_domain_limits.py
<https://reviews.apache.org/r/13001/#comment49636>

    as the test title says "reboot_instance", please use reboot instance API.



test/integration/component/cpu_limits/test_domain_limits.py
<https://reviews.apache.org/r/13001/#comment49637>

    use different limits then what you have set for cadmin_1, it will help in checking more
test cases.



test/integration/component/cpu_limits/test_domain_limits.py
<https://reviews.apache.org/r/13001/#comment49638>

    if i am not wrong, the api_client should be api_client_cadmin_2


- Sanjay Tripathi


On Aug. 8, 2013, 12:51 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13001/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2013, 12:51 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, sailaja mada, Sanjay Tripathi, and Prasanna
Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Adding test cases for CPU limits from Limit Resources.
> Marvin changes have to be picked up from Memory Limits patch (https://reviews.apache.org/r/11626/).
Those are not included in this patch.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/cpu_limits/test_cpu_limits.py PRE-CREATION 
>   test/integration/component/cpu_limits/test_domain_limits.py PRE-CREATION 
>   test/integration/component/cpu_limits/test_maximum_limits.py PRE-CREATION 
>   test/integration/component/cpu_limits/test_project_limits.py PRE-CREATION 
>   tools/marvin/marvin/integration/lib/base.py b5d086b 
>   tools/marvin/marvin/integration/lib/common.py 4f5acef 
> 
> Diff: https://reviews.apache.org/r/13001/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message