cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Koushik Das" <koushik....@citrix.com>
Subject Review Request 13627: Fix for CLOUDSTACK-3441
Date Sat, 17 Aug 2013 09:05:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13627/
-----------------------------------------------------------

Review request for cloudstack, Alex Huang, Abhinandan Prateek, Chiradeep Vittal, and Murali
Reddy.


Bugs: CLOUDSTACK-3441


Repository: cloudstack-git


Description
-------

CLOUDSTACK-3441: [Load Test] High delays between VM being allocated to Pod and network implementation
causing delays in VM deployment

The locking code in implement/shutdown network code was not efficient. Even in order to check
the current state of the network lock was getting acquired which is not required. This resulted
in delays in deploy VM as can be seen from attached logs where the code waited on the lock
just to check if network is implemented.

As part of the fix moved out code that is checking if the network is already implemented or
shutdowned outside the lock.


Diffs
-----

  server/src/com/cloud/network/NetworkManagerImpl.java 68b1b4f 

Diff: https://reviews.apache.org/r/13627/diff/


Testing
-------


Thanks,

Koushik Das


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message