cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Federle" <brian.fede...@citrix.com>
Subject Re: Review Request 13131: Default field identifier
Date Wed, 14 Aug 2013 17:36:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13131/#review25155
-----------------------------------------------------------

Ship it!


Ship It!

- Brian Federle


On Aug. 2, 2013, 1:38 p.m., Chris Suich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13131/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2013, 1:38 p.m.)
> 
> 
> Review request for cloudstack, Brian Federle, Jessica Wang, and Pranav Saxena.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Currently, the identifying value of json objects is assumed to be 'id' or 'name' (if
'id' doesn't exist). I have added the option of allowing fields to specify which json property
should be the identifying value of an object.
> 
> For some reason, it says that ui/scripts/ui/dialog.js can not be found in the repository,
so I have added the patch file manually. Please let me know if there is some way to fix this.
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://reviews.apache.org/r/13131/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> 
>   https://reviews.apache.org/media/uploaded/files/2013/07/31/field-identify-value.patch
> 
> 
> Thanks,
> 
> Chris Suich
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message