cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hugo Trippaers" <htrippa...@schubergphilis.com>
Subject Re: Review Request 12941: [GSoC] refactor gre controller
Date Mon, 12 Aug 2013 11:31:56 GMT


> On Aug. 12, 2013, 11:30 a.m., Hugo Trippaers wrote:
> > Ship It!

Targeted to the sdnextensions branch.

Commit id : 0d6125f36449b1fcbbc5d296496c4a01f2208fc4


- Hugo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12941/#review24990
-----------------------------------------------------------


On Aug. 1, 2013, 1:41 a.m., tuna wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12941/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2013, 1:41 a.m.)
> 
> 
> Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> I made an update to refactor gre controller:
> 
> + remove ovs_devices table, because we'll have an ODL plugin separately.
> + move command/answer to new package: com.cloud.agent.api
> + add Connectivity service checking
> + add new NetworkProvider: Ovs
> + add L3 services to Ovs Capabilities
> + add L3 services prototype code.
> 
> Next step:
> + L3 services implement with VirtualRouter
> + ODL plugin
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/network/Network.java a06208b 
>   api/src/com/cloud/network/OvsProvider.java PRE-CREATION 
>   api/src/com/cloud/network/element/VirtualRouterElementService.java ea971b8 
>   api/src/org/apache/cloudstack/api/ResponseGenerator.java d8d07cb 
>   api/src/org/apache/cloudstack/api/command/admin/router/ConfigureOvsElementCmd.java
PRE-CREATION 
>   api/src/org/apache/cloudstack/api/command/admin/router/ListOvsElementsCmd.java PRE-CREATION

>   api/src/org/apache/cloudstack/api/response/OvsProviderResponse.java PRE-CREATION 
>   client/tomcatconf/applicationContext.xml.in 60f1e30 
>   client/tomcatconf/commands.properties.in 6ec4d92 
>   engine/schema/src/com/cloud/network/dao/OvsProviderDao.java PRE-CREATION 
>   engine/schema/src/com/cloud/network/dao/OvsProviderDaoImpl.java PRE-CREATION 
>   engine/schema/src/com/cloud/network/element/OvsProviderVO.java PRE-CREATION 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
30b0521 
>   plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelAnswer.java
PRE-CREATION 
>   plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelCommand.java
PRE-CREATION 
>   plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelAnswer.java PRE-CREATION

>   plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelCommand.java PRE-CREATION

>   plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDeleteFlowCommand.java PRE-CREATION

>   plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyBridgeCommand.java PRE-CREATION

>   plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyTunnelCommand.java PRE-CREATION

>   plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceAnswer.java PRE-CREATION

>   plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceCommand.java
PRE-CREATION 
>   plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowAnswer.java PRE-CREATION

>   plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowCommand.java PRE-CREATION

>   plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetupBridgeCommand.java PRE-CREATION

>   plugins/network-elements/ovs/src/com/cloud/agent/api/StartupOvsCommand.java PRE-CREATION

>   plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java 0ea6b52

>   plugins/network-elements/ovs/src/com/cloud/network/element/OvsElementService.java b55fe6b

>   plugins/network-elements/ovs/src/com/cloud/network/guru/OvsGuestNetworkGuru.java bbdf110

>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java b1ecaac

>   scripts/vm/hypervisor/xenserver/ovstunnel a4760b2 
>   server/src/com/cloud/api/ApiResponseHelper.java 090d9c2 
>   server/src/com/cloud/network/NetworkServiceImpl.java d4f9030 
>   server/src/com/cloud/network/element/VirtualRouterElement.java 1916678 
>   server/src/com/cloud/server/ManagementServerImpl.java 36b3879 
>   setup/db/create-schema.sql 143023a 
>   setup/db/db/schema-410to420.sql b48ae6a 
>   tools/apidoc/gen_toc.py 33a7e75 
>   ui/scripts/zoneWizard.js e2ad910 
> 
> Diff: https://reviews.apache.org/r/12941/diff/
> 
> 
> Testing
> -------
> 
> Test done with following cases:
> 
> + choose GRE method, VLAN range when deploy advanced zone
> + create new Network Offering and choose Ovs for VirtualNetworking service, VirtualRouter
for other services.
> + create a new Guest network using this new NetworkOffering
> + deploy VMs on this Guest network
> + stop, restart, destroy VMs
> + deploy, stop, restart, destroy VMs on two hosts.
> 
> 
> Thanks,
> 
> tuna
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message