cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasanna Santhanam" <...@apache.org>
Subject Re: Review Request 13482: Fix test_snapshots script to choose the right device name while mounting and other minor script issues
Date Mon, 12 Aug 2013 05:29:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13482/#review24982
-----------------------------------------------------------



test/integration/component/test_snapshots.py
<https://reviews.apache.org/r/13482/#comment49149>

    Remove the "hello" tag



test/integration/component/test_snapshots.py
<https://reviews.apache.org/r/13482/#comment49148>

    It's better to have one master list with all device names to avoid putting the if-else
logic everywhere. I guess that makes correcting the test expensive when a new device name
needs to be added. 
    
    Also you'll miss partitioned disks of the form /dev/hdb1, /dev/hdb2 etc that some vmware
guests have using this patch.


- Prasanna Santhanam


On Aug. 11, 2013, 7:28 a.m., SrikanteswaraRao Talluri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13482/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2013, 7:28 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-4096
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Following are the fixes:
> 1. don't rely on prepopulated data for choosing the disk to be mounted
>    a. get the list of volumes
>    b. take the latest volume and add the proper device name for each hypervisor
>       xenserver - /dev/xvd{a|b...}
>       vmware - /dev/sd{a|b|..}
>       kvm - /dev/vd{a|b|...}
> 2. Get the right volume for taking snapshot.
> and other script issues are also fixed.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_snapshots.py b97a83a 
> 
> Diff: https://reviews.apache.org/r/13482/diff/
> 
> 
> Testing
> -------
> 
> tested
> 
> 
> Thanks,
> 
> SrikanteswaraRao Talluri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message