cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Cahill" <dcah...@midokura.com>
Subject Re: Review Request 12849: added backwards compatibility code to Networks enums
Date Wed, 07 Aug 2013 09:06:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12849/#review24787
-----------------------------------------------------------


Three minor comments, but my main concerns are addressed by this diff.


api/src/com/cloud/network/Networks.java
<https://reviews.apache.org/r/12849/#comment48907>

    Should this say isolation URI instead of broadcast URI?



api/test/com/cloud/network/NetworksTest.java
<https://reviews.apache.org/r/12849/#comment48905>

    Not important, but I think this should be "of broadcasttype lswitch".



api/test/com/cloud/network/NetworksTest.java
<https://reviews.apache.org/r/12849/#comment48906>

    Not important, but I think this should be "of broadcasttype mido".


- Dave Cahill


On Aug. 7, 2013, 8:50 a.m., daan Hoogland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12849/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2013, 8:50 a.m.)
> 
> 
> Review request for cloudstack, Chiradeep Vittal, Dave Cahill, Koushik Das, and Sheng
Yang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Both BroadcastDomainType and IsolationType needed some extra code for backwards compatibility
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/network/Networks.java c76c3d4 
>   api/test/com/cloud/network/NetworksTest.java 31114e8 
> 
> Diff: https://reviews.apache.org/r/12849/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> daan Hoogland
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message