cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rajesh Battala" <rajesh.batt...@citrix.com>
Subject Review Request 13319: [KVM] [PrimaryStorage] deleteStoragePool is not removing the storage pool information from KVM agent/host.
Date Tue, 06 Aug 2013 11:23:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13319/
-----------------------------------------------------------

Review request for cloudstack, Devdeep Singh, edison su, and Ram Ganesh.


Bugs: 3887


Repository: cloudstack-git


Description
-------

Issue:
======
[KVM] [PrimaryStorage] deleteStoragePool is not removing the storage pool information from
KVM agent/host.

root cause:
========== 
   In the CloudstackPrimaryDatastorelifecycleImpl class, deletedataStore method  when storage
is getting deleted which is attached to kvm hosts, from the list of hosts only for first host
Agentcmd is sent to remove the storage.
In case of xenserver this will work as the xapi will take care of removing the storagepool
from its slaves. 

   In case of KVM we need to send to all hosts to remove the storage. 

Fixed:
======
Fixed by sending the agent command to all the hosts if the storage pool is attached to KVM
type hypervisor.


Diffs
-----

  plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java
2c8c871 

Diff: https://reviews.apache.org/r/13319/diff/


Testing
-------

1. Created a zone with two kvm hosts and one xenserver host 
2. Created cluster scope primary storage for kvm cluster, storage got mounted on both kvm
hosts.
3. Enabled maintenance on storage and removed the storage pool.
4. Storage got successfully umount from both the hosts. virsh-pool is not listing the removed
storage pool.

5. Created ZONE scope PS, storage got mounted in both the KVM hosts. 
6  Storage got successfully umount from both the hosts. virsh-pool is not listing the removed
storage pool.

7. created cluster scope for Xenserver Cluster. 
8. Enabled maintenance on storage and removed the storage pool.
9. Storage got successfully umount from both xenserver.


Thanks,

Rajesh Battala


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message