cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jayapal Reddy" <jayapalreddy.ur...@citrix.com>
Subject Re: Review Request 12934: Tests for egress firewall rules for advance zone
Date Mon, 05 Aug 2013 09:55:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12934/#review24640
-----------------------------------------------------------



test/integration/component/test_egress_fw_rules.py
<https://reviews.apache.org/r/12934/#comment48746>

    remove the white space (red colour).
    Please apply the patch in your local and make sure there is no warning.
    # git apply patchName.patch



test/integration/component/test_egress_fw_rules.py
<https://reviews.apache.org/r/12934/#comment48747>

    do we need specify vlan here ?



test/integration/component/test_egress_fw_rules.py
<https://reviews.apache.org/r/12934/#comment48748>

    Hard coding vlan may not work for others setups.
    If specify vlan is set then query the free vlan id


- Jayapal Reddy


On Aug. 1, 2013, 6:19 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12934/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2013, 6:19 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, Jayapal Reddy, and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Tests for egress firewall rules for advance zone.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_egress_fw_rules.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12934/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message