cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasanna Santhanam" <...@apache.org>
Subject Re: Review Request 12934: Tests for egress firewall rules for advance zone
Date Mon, 05 Aug 2013 07:15:21 GMT


> On Aug. 2, 2013, 10:29 a.m., Jayapal Reddy wrote:
> > test/integration/component/test_egress_fw_rules.py, line 55
> > <https://reviews.apache.org/r/12934/diff/4/?file=332296#file332296line55>
> >
> >     I appreciate your effort in correcting the test cases.
> >     There are few comments from my side. Please fix those.
> >     Also the script is failed to run.Also look into this. The below exception is
thrown
> >     
> >     
> >     integration.component.test_egress_fw_rules.log_test_exceptions ... ERROR
> >     
> >     ======================================================================
> >     ERROR: integration.component.test_egress_fw_rules.log_test_exceptions
> >     ----------------------------------------------------------------------
> >     Traceback (most recent call last):
> >       File "/Library/Python/2.7/site-packages/nose/case.py", line 197, in runTest
> >         self.test(*self.arg)
> >     TypeError: log_test_exceptions() takes exactly 1 argument (0 given)
> >
> 
> Ashutosh Kelkar wrote:
>     I am able to run the script without any issue.
>     python2.7 -m marvin.deployAndRun -c  $TESTPATH/run.cfg -d $TESTPATH -r /var/log/cs4.2.x-result.log
-t /var/log/cs4.2.x-client.log -l &
>     testpid=$!
>     tail --pid $testpid -f /var/log/cs4.2.x-result.log /var/log/cs4.2.x-client.log
>     Let me know if you are still facing issues running the tests.

The reason why this won't run using nosetests is that the testrunner in nose needs the testnames
to start with the test_ prefix. When you wrap the decorator over each test the name of the
method changes. Check the test_assign_vm.py where I made the fix. Since you are using the
logger decorator often why not also move it to the utils/common module?


- Prasanna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12934/#review24517
-----------------------------------------------------------


On Aug. 1, 2013, 6:19 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12934/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2013, 6:19 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, Jayapal Reddy, and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Tests for egress firewall rules for advance zone.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_egress_fw_rules.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12934/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message