cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Kelkar" <ashut...@clogeny.com>
Subject Re: Review Request 12934: Tests for egress firewall rules for advance zone
Date Mon, 05 Aug 2013 04:34:01 GMT


> On Aug. 2, 2013, 10:29 a.m., Jayapal Reddy wrote:
> > test/integration/component/test_egress_fw_rules.py, line 676
> > <https://reviews.apache.org/r/12934/diff/4/?file=332296#file332296line676>
> >
> >     change the comment.
> >     Egress policy is true

Done.


> On Aug. 2, 2013, 10:29 a.m., Jayapal Reddy wrote:
> > test/integration/component/test_egress_fw_rules.py, line 679
> > <https://reviews.apache.org/r/12934/diff/4/?file=332296#file332296line679>
> >
> >     fix the comment.
> >     access to public network for tcp port 80 is blocked.

Done.


> On Aug. 2, 2013, 10:29 a.m., Jayapal Reddy wrote:
> > test/integration/component/test_egress_fw_rules.py, line 785
> > <https://reviews.apache.org/r/12934/diff/4/?file=332296#file332296line785>
> >
> >     Egress policy is not set to false, but comment says false. The above test case
is already set to true

Done.


> On Aug. 2, 2013, 10:29 a.m., Jayapal Reddy wrote:
> > test/integration/component/test_egress_fw_rules.py, line 819
> > <https://reviews.apache.org/r/12934/diff/4/?file=332296#file332296line819>
> >
> >     Fix the comment, invalid cidr is passed to create the rule

Done.


> On Aug. 2, 2013, 10:29 a.m., Jayapal Reddy wrote:
> > test/integration/component/test_egress_fw_rules.py, line 837
> > <https://reviews.apache.org/r/12934/diff/4/?file=332296#file332296line837>
> >
> >     Invalid cidr is not passed to rule. fix the comment

Done.


> On Aug. 2, 2013, 10:29 a.m., Jayapal Reddy wrote:
> > test/integration/component/test_egress_fw_rules.py, line 856
> > <https://reviews.apache.org/r/12934/diff/4/?file=332296#file332296line856>
> >
> >     Fix the comment

Done


> On Aug. 2, 2013, 10:29 a.m., Jayapal Reddy wrote:
> > test/integration/component/test_egress_fw_rules.py, line 912
> > <https://reviews.apache.org/r/12934/diff/4/?file=332296#file332296line912>
> >
> >     Fix the comment

Done


> On Aug. 2, 2013, 10:29 a.m., Jayapal Reddy wrote:
> > test/integration/component/test_egress_fw_rules.py, line 55
> > <https://reviews.apache.org/r/12934/diff/4/?file=332296#file332296line55>
> >
> >     I appreciate your effort in correcting the test cases.
> >     There are few comments from my side. Please fix those.
> >     Also the script is failed to run.Also look into this. The below exception is
thrown
> >     
> >     
> >     integration.component.test_egress_fw_rules.log_test_exceptions ... ERROR
> >     
> >     ======================================================================
> >     ERROR: integration.component.test_egress_fw_rules.log_test_exceptions
> >     ----------------------------------------------------------------------
> >     Traceback (most recent call last):
> >       File "/Library/Python/2.7/site-packages/nose/case.py", line 197, in runTest
> >         self.test(*self.arg)
> >     TypeError: log_test_exceptions() takes exactly 1 argument (0 given)
> >

I am able to run the script without any issue.
python2.7 -m marvin.deployAndRun -c  $TESTPATH/run.cfg -d $TESTPATH -r /var/log/cs4.2.x-result.log
-t /var/log/cs4.2.x-client.log -l &
testpid=$!
tail --pid $testpid -f /var/log/cs4.2.x-result.log /var/log/cs4.2.x-client.log
Let me know if you are still facing issues running the tests.


- Ashutosh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12934/#review24517
-----------------------------------------------------------


On Aug. 1, 2013, 6:19 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12934/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2013, 6:19 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, Jayapal Reddy, and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Tests for egress firewall rules for advance zone.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_egress_fw_rules.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12934/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message