cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "bharat kumar" <bharat.ku...@citrix.com>
Subject Re: Review Request 13112: upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes"
Date Thu, 01 Aug 2013 16:51:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13112/
-----------------------------------------------------------

(Updated Aug. 1, 2013, 4:51 p.m.)


Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.


Changes
-------

rebased with master.


Bugs: Cloudstack-3836


Repository: cloudstack-git


Description
-------

upgrade to ASF 4.2  "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table
"volumes"
https://issues.apache.org/jira/browse/CLOUDSTACK-3836

This extra column is because of the fix 
Parent id of template incorrectly recorded as last ISO attached to VM.

when a template is created form the snapshot the sourcetemplateid is recorded as the iso attached
to the VM at thee time of creation. 

we fix this by adding a iso_id column to the volume table. when a template is created from
the snapshot we fetch the iso_id form the parent volume and set it as the sourcetemplated
id of the newly created template.


Diffs (updated)
-----

  engine/schema/src/com/cloud/storage/VolumeVO.java 1445e99 
  server/src/com/cloud/storage/VolumeManager.java 13ddbab 
  server/src/com/cloud/storage/VolumeManagerImpl.java 3cce8b6 
  server/src/com/cloud/template/TemplateManagerImpl.java d26ebe2 
  server/src/com/cloud/vm/VirtualMachineManagerImpl.java 5b7aa5b 
  setup/db/db/schema-307to410.sql be6c17d 
  setup/db/db/schema-410to420.sql 99a0208 

Diff: https://reviews.apache.org/r/13112/diff/


Testing
-------

Tested on 4.2.


Thanks,

bharat kumar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message