cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasanna Santhanam" <...@apache.org>
Subject Re: Review Request 13109: CLOUDSTACK-3594: Fixes related to affinity groups
Date Thu, 01 Aug 2013 08:26:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13109/#review24426
-----------------------------------------------------------



test/integration/component/test_affinity_groups.py
<https://reviews.apache.org/r/13109/#comment48348>

    use utils.randomgen()



tools/marvin/marvin/integration/lib/base.py
<https://reviews.apache.org/r/13109/#comment48347>

    For every API in base, just use the prefix verb before the Cloud resource as the name
of the method. 
    
    So createXxx, updateXxx, deleteXxx transforms into Xxx.create(), Xxx.update, Xxx.delete()
    
    IOW, rename update_affinity_group to just update()
    
    


- Prasanna Santhanam


On July 31, 2013, 12:13 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13109/
> -----------------------------------------------------------
> 
> (Updated July 31, 2013, 12:13 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fixed test case issues mentioned in issue https://issues.apache.org/jira/browse/CLOUDSTACK-3594
> 
> Radom-ized affinity group name to avoid cascading test case failures stating "unable
to create affinity group due to affinity group with the same name exists".
> 
> Included following 2 test suites which were not run in last build because there was no
decorator for the test cases.
> 1. TestListAffinityGroups
> 2. TestUpdateVMAffinityGroups
> 
> One test case in TestUpdateVMAffinityGroups is skipped, it's failing right now. Will
be fixed shortly.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_affinity_groups.py 3ecab6f 
>   tools/marvin/marvin/integration/lib/base.py b552aba 
> 
> Diff: https://reviews.apache.org/r/13109/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message