cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request 12264: CLOUDSTACK-3351: Fix add cluster API to set right hypervisor type
Date Thu, 01 Aug 2013 08:22:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12264/#review24425
-----------------------------------------------------------


Commit b4fe0252230e74d36f62679cd2a751f278edacc1 in branch refs/heads/4.2 from Harikrishna
Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b4fe025 ]

CLOUDSTACK-3351: Fix add cluster API to set right hypervisor type

Signed-off-by: Abhinandan Prateek <aprateek@apache.org>


- ASF Subversion and Git Services


On July 4, 2013, 8:40 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12264/
> -----------------------------------------------------------
> 
> (Updated July 4, 2013, 8:40 a.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: CLOUDSTACK-3351
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-3351: Fix add cluster API to set right hypervisor type
> In AddCluster API we validate Hypervisor type parameter even if it is case insensitive.
We should not put this case insensitive value in the DB which may lead to mismatch with hypervisor
type with other tables in DB leading to failure of various DB queries.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/resource/ResourceManagerImpl.java c6e8d7d 
> 
> Diff: https://reviews.apache.org/r/12264/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message