cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Brosius" <dbros...@mebigfatguy.com>
Subject Re: Review Request 12192: set the field 'state' rather than the unread parameter 'state', if the parameter is null
Date Thu, 01 Aug 2013 01:30:55 GMT


> On July 2, 2013, 7:11 a.m., daan Hoogland wrote:
> > Your change seems fine.
> > 
> > Did you regression test it? Or did you solve a problem with it?

Just noticed during code inspection


- Dave


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12192/#review22650
-----------------------------------------------------------


On June 29, 2013, 9:08 p.m., Dave Brosius wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12192/
> -----------------------------------------------------------
> 
> (Updated June 29, 2013, 9:08 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> code checks the parameter 'state' and if null, set it to Allocated, even though that
parameter is never accessed. Meant to set the field 'state'.
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/network/dao/NetworkVO.java 6580ea0 
> 
> Diff: https://reviews.apache.org/r/12192/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dave Brosius
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message