Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 07AD4104E9 for ; Tue, 16 Jul 2013 05:24:27 +0000 (UTC) Received: (qmail 73082 invoked by uid 500); 16 Jul 2013 05:24:25 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 72760 invoked by uid 500); 16 Jul 2013 05:24:22 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 72743 invoked by uid 500); 16 Jul 2013 05:24:21 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 72739 invoked by uid 99); 16 Jul 2013 05:24:21 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jul 2013 05:24:21 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS,URIBL_DBL_REDIR X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of Chiradeep.Vittal@citrix.com designates 66.165.176.63 as permitted sender) Received: from [66.165.176.63] (HELO SMTP02.CITRIX.COM) (66.165.176.63) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jul 2013 05:24:16 +0000 X-IronPort-AV: E=Sophos;i="4.89,674,1367971200"; d="scan'208";a="35370708" Received: from sjcpex01cl01.citrite.net ([10.216.14.143]) by FTLPIPO02.CITRIX.COM with ESMTP/TLS/AES128-SHA; 16 Jul 2013 05:23:54 +0000 Received: from SJCPEX01CL02.citrite.net ([169.254.2.91]) by SJCPEX01CL01.citrite.net ([10.216.14.143]) with mapi id 14.02.0342.004; Mon, 15 Jul 2013 22:23:53 -0700 From: Chiradeep Vittal To: "dev@cloudstack.apache.org" , "Prasanna Santhanam" , cloudstack , Sheng Yang Subject: Re: Review Request 11977: Re-enabling baremetal for 4.2/master Thread-Topic: Review Request 11977: Re-enabling baremetal for 4.2/master Thread-Index: AQHOdVwMkrzWF8H8Ok2uIbz9UBINCplnsByA Date: Tue, 16 Jul 2013 05:23:52 +0000 Message-ID: In-Reply-To: <20130630063529.23541.40477@reviews.apache.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.5.130515 x-originating-ip: [10.216.48.12] Content-Type: text/plain; charset="us-ascii" Content-ID: <5D967A7DB53D224280A0C1828787D2E1@citrix.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org This actually breaks basic zone and re-opens bug CLOUDSTACK-1812 On 6/30/13 12:05 PM, "Prasanna Santhanam" wrote: > >----------------------------------------------------------- >This is an automatically generated e-mail. To reply, visit: >https://reviews.apache.org/r/11977/#review22577 >----------------------------------------------------------- > > >This was submitted. Closing the review >http://cloudstack.markmail.org/thread/xfx4sjwyurnyn2xo > >- Prasanna Santhanam > > >On June 19, 2013, 5:59 p.m., Sheng Yang wrote: >>=20 >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/11977/ >> ----------------------------------------------------------- >>=20 >> (Updated June 19, 2013, 5:59 p.m.) >>=20 >>=20 >> Review request for cloudstack. >>=20 >>=20 >> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3077 >>=20 >>=20 >> Repository: cloudstack-git >>=20 >>=20 >> Description >> ------- >>=20 >> This patch would re-enable baremetal support for master, which we've >>disabled on 4.1 release due to release blocker bugs. >>=20 >> After review passed, I would apply the patch to master in small patches. >>=20 >>=20 >> Diffs >> ----- >>=20 >> client/pom.xml ab758eb >> client/tomcatconf/applicationContext.xml.in 049e483 >> client/tomcatconf/componentContext.xml.in 93ef21f >> client/tomcatconf/nonossComponentContext.xml.in 143aa22 >> =20 >>plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BareMetalDi >>scoverer.java edb5dea >> =20 >>plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BareMetalTe >>mplateAdapter.java 928183b >> =20 >>plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/Bare >>metalDhcpElement.java fdf8b63 >> =20 >>plugins/network-elements/dns-notifier/resources/components-example.xml >>2e9c5be=20 >> server/src/com/cloud/configuration/Config.java f6fa974 >> server/src/com/cloud/network/NetworkServiceImpl.java aace68d >> setup/db/db/schema-410to420.sql bcdf2d9 >>=20 >> Diff: https://reviews.apache.org/r/11977/diff/ >>=20 >>=20 >> Testing >> ------- >>=20 >> All the following bugs(which are the original blocker for 4.1 releases) >>are tested against the patch. >>=20 >> https://issues.apache.org/jira/browse/CLOUDSTACK-1610 >> https://issues.apache.org/jira/browse/CLOUDSTACK-1618 >> https://issues.apache.org/jira/browse/CLOUDSTACK-1614 >> https://issues.apache.org/jira/browse/CLOUDSTACK-1440 >>=20 >>=20 >> Thanks, >>=20 >> Sheng Yang >>=20 >> >