Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ECDB2104AD for ; Wed, 31 Jul 2013 22:10:59 +0000 (UTC) Received: (qmail 34475 invoked by uid 500); 31 Jul 2013 22:10:59 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 34428 invoked by uid 500); 31 Jul 2013 22:10:59 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 34417 invoked by uid 500); 31 Jul 2013 22:10:59 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 34406 invoked by uid 99); 31 Jul 2013 22:10:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Jul 2013 22:10:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1059D1D1323; Wed, 31 Jul 2013 22:10:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3453378274531522027==" MIME-Version: 1.0 Subject: Re: Review Request 12958: Automation test failure: can't attach volume to a stopped created VM. Fix the null pointer From: "Fang Wang" To: "Prasanna Santhanam" , "edison su" Cc: "cloudstack" , "Jenkins Cloudstack.org" , "Fang Wang" , "Rayees Namathponnan" Date: Wed, 31 Jul 2013 22:10:58 -0000 Message-ID: <20130731221058.6985.74766@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Fang Wang" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/12958/ X-Sender: "Fang Wang" References: <20130725231500.32008.30182@reviews.apache.org> In-Reply-To: <20130725231500.32008.30182@reviews.apache.org> Reply-To: "Fang Wang" --===============3453378274531522027== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12958/ ----------------------------------------------------------- (Updated July 31, 2013, 10:10 p.m.) Review request for cloudstack, edison su and Prasanna Santhanam. Changes ------- Hi Edison, PRasanna, would you review it? I did built and test. Thanks. Bugs: CLOUDSTACK-3759 Repository: cloudstack-git Description ------- When the new VM is created and put in stopped state, the volume and pool is not allocated. Hence the NPE. Diffs ----- server/src/com/cloud/storage/VolumeManagerImpl.java d7d62b0 Diff: https://reviews.apache.org/r/12958/diff/ Testing ------- Thanks, Fang Wang --===============3453378274531522027==--