Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 665C810B29 for ; Wed, 31 Jul 2013 05:51:58 +0000 (UTC) Received: (qmail 68901 invoked by uid 500); 31 Jul 2013 05:51:57 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 68600 invoked by uid 500); 31 Jul 2013 05:51:57 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 68585 invoked by uid 500); 31 Jul 2013 05:51:56 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 68574 invoked by uid 99); 31 Jul 2013 05:51:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Jul 2013 05:51:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0A7BF1D11D4; Wed, 31 Jul 2013 05:51:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0804457073665342609==" MIME-Version: 1.0 Subject: Re: Review Request 13058: unable to update the concurrent_connections in networkoffering. From: "bharat kumar" To: "Abhinandan Prateek" Cc: "cloudstack" , "Jenkins Cloudstack.org" , "bharat kumar" Date: Wed, 31 Jul 2013 05:51:55 -0000 Message-ID: <20130731055155.3449.88743@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "bharat kumar" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/13058/ X-Sender: "bharat kumar" References: <20130730105205.30961.49200@reviews.apache.org> In-Reply-To: <20130730105205.30961.49200@reviews.apache.org> Reply-To: "bharat kumar" --===============0804457073665342609== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13058/ ----------------------------------------------------------- (Updated July 31, 2013, 5:51 a.m.) Review request for cloudstack and Abhinandan Prateek. Changes ------- rebased with master. Bugs: Cloudstack-2997 Repository: cloudstack-git Description ------- https://issues.apache.org/jira/browse/CLOUDSTACK-2997 cloud not update the concurrent_connections parameter of networkoffering because of some dao dependency. The update was not happening because of choosing a VO variable name having a underscore. Diffs (updated) ----- api/src/org/apache/cloudstack/api/response/NetworkOfferingResponse.java 6b35d7b engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java b0cb85d server/src/com/cloud/api/ApiResponseHelper.java c1ae7d0 server/src/com/cloud/configuration/ConfigurationManagerImpl.java d5e6c00 Diff: https://reviews.apache.org/r/13058/diff/ Testing ------- Tested on 4.2 Thanks, bharat kumar --===============0804457073665342609==--