Return-Path: 
 <dev-return-39553-apmail-cloudstack-dev-archive=cloudstack.apache.org@cloudstack.apache.org>
X-Original-To: apmail-cloudstack-dev-archive@www.apache.org
Delivered-To: apmail-cloudstack-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 5A4A4107D0
	for <apmail-cloudstack-dev-archive@www.apache.org>;
 Tue, 30 Jul 2013 08:47:24 +0000 (UTC)
Received: (qmail 65375 invoked by uid 500); 30 Jul 2013 08:47:21 -0000
Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org
Received: (qmail 65341 invoked by uid 500); 30 Jul 2013 08:47:19 -0000
Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cloudstack.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cloudstack.apache.org>
List-Post: <mailto:dev@cloudstack.apache.org>
List-Id: <dev.cloudstack.apache.org>
Reply-To: dev@cloudstack.apache.org
Delivered-To: mailing list dev@cloudstack.apache.org
Received: (qmail 65328 invoked by uid 500); 30 Jul 2013 08:47:18 -0000
Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org
Received: (qmail 65322 invoked by uid 99); 30 Jul 2013 08:47:17 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Jul 2013 08:47:17 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id A076A1D10D2;
	Tue, 30 Jul 2013 08:47:15 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============7160738200432613390=="
MIME-Version: 1.0
Subject: Re: Review Request 12905: Multiple VLAN range API need to accept a
 list
 rather than "add" or "remove" per command
From: "bharat kumar" <bharat.kumar@citrix.com>
To: "Alena Prokharchyk" <alena.prokharchyk@citrix.com>,
 "Sheng Yang" <sheng@yasker.org>
Cc: "cloudstack" <cloudstack-dev@incubator.apache.org>,
 "bharat kumar" <bharat.kumar@citrix.com>
Date: Tue, 30 Jul 2013 08:47:15 -0000
Message-ID: <20130730084715.3449.6271@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "bharat kumar" <noreply@reviews.apache.org>
X-ReviewGroup: cloudstack
X-ReviewRequest-URL: https://reviews.apache.org/r/12905/
X-Sender: "bharat kumar" <noreply@reviews.apache.org>
References: <20130729204537.3449.89924@reviews.apache.org>
In-Reply-To: <20130729204537.3449.89924@reviews.apache.org>
Reply-To: "bharat kumar" <bharat.kumar@citrix.com>

--===============7160738200432613390==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit



> On July 29, 2013, 8:45 p.m., Alena Prokharchyk wrote:
> > 1) DataCenterVnetDaoImpl.java
> > 
> > deleteRange method.
> > 
> > List<String> vnets - this type is very ambigous. How is it represented? 100-200? 100,101,102,103? People are going to use this method, you either have to document it well, or use diff datastructure.
> > 
> > 2) Not able to re-set the range back to NULL
> > 
> > 3) The main concern:
> > 
> > createPhysicalNetwork should work just as updatePhysicalNetwork. Right now it fails:
> > 
> > http://localhost:8096/?command=createPhysicalNetwork&name=200&vlan=1-2,6-100&zoneId=1
> > 
> > <createphysicalnetworkresponse cloud-stack-version="4.2.0-SNAPSHOT">
> > <errorcode>431</errorcode>
> > <cserrorcode>4350</cserrorcode>
> > <errortext>Please specify valid integers for the vlan range.</errortext>
> > </createphysicalnetworkresponse>

fixed these issues.


- bharat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12905/#review24171
-----------------------------------------------------------


On July 30, 2013, 8:46 a.m., bharat kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12905/
> -----------------------------------------------------------
> 
> (Updated July 30, 2013, 8:46 a.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk and Sheng Yang.
> 
> 
> Bugs: Cloudstack-3753
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-3753
> Multiple VLAN range API need to accept a list rather than "add" or "remove" per command
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/network/NetworkService.java 59ccdbf 
>   api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 333564e 
>   engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java e2e6b79 
>   engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java ced2982 
>   server/src/com/cloud/network/NetworkServiceImpl.java f1f71ca 
>   server/test/com/cloud/network/MockNetworkManagerImpl.java 4577d0a 
>   server/test/com/cloud/network/UpdatePhysicalNetworkTest.java e3fc36a 
>   server/test/com/cloud/vpc/MockNetworkManagerImpl.java fd61bc6 
> 
> Diff: https://reviews.apache.org/r/12905/diff/
> 
> 
> Testing
> -------
> 
> Tested on master.
> removed the removevlan parameter.
> vlan parameter can be used for both addition and removal of valns.
> instead of passing only a vlan range. user has to pass all the vlan ranges that he wants to keep.
> the vlan ranges missing in the input and present in the db (not allocated) will be removed.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>


--===============7160738200432613390==--