Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F1A921022C for ; Mon, 29 Jul 2013 14:38:05 +0000 (UTC) Received: (qmail 32328 invoked by uid 500); 29 Jul 2013 14:38:05 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 32154 invoked by uid 500); 29 Jul 2013 14:38:04 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 31766 invoked by uid 500); 29 Jul 2013 14:38:03 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 31756 invoked by uid 99); 29 Jul 2013 14:38:03 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Jul 2013 14:38:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 419031D0E6B; Mon, 29 Jul 2013 14:38:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3799612619988403682==" MIME-Version: 1.0 Subject: Re: Review Request 12942: CLOUDSTACK-3454: Fix test_portable_publicip From: "Prasanna Santhanam" To: "Prasanna Santhanam" , "Murali Reddy" Cc: "Girish Shilamkar" , "cloudstack" Date: Mon, 29 Jul 2013 14:38:02 -0000 Message-ID: <20130729143802.30929.97446@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Prasanna Santhanam" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/12942/ X-Sender: "Prasanna Santhanam" References: <20130725125041.32328.37707@reviews.apache.org> In-Reply-To: <20130725125041.32328.37707@reviews.apache.org> Reply-To: "Prasanna Santhanam" --===============3799612619988403682== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12942/#review24129 ----------------------------------------------------------- Ship it! - Prasanna Santhanam On July 25, 2013, 12:50 p.m., Girish Shilamkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12942/ > ----------------------------------------------------------- > > (Updated July 25, 2013, 12:50 p.m.) > > > Review request for cloudstack, Murali Reddy and Prasanna Santhanam. > > > Bugs: CLOUDSTACK-3454 > > > Repository: cloudstack-git > > > Description > ------- > > Added isportable param to associateIP API. Fixed base class > for PortableIP tio call portableip APIs. > Removed test_createPortablePublicIPAcquire from basic zone run > requires additional network creation handling which can be done > in component tests. > > > Diffs > ----- > > test/integration/smoke/test_portable_publicip.py 9a3a398 > tools/marvin/marvin/integration/lib/base.py 0f6fdc5 > > Diff: https://reviews.apache.org/r/12942/diff/ > > > Testing > ------- > > Yes, but disassociating ip address fails. Maybe a product defect, yet to investigate. > > > Thanks, > > Girish Shilamkar > > --===============3799612619988403682==--