Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============6041562181421637721=="
MIME-Version: 1.0
Subject: Re: Review Request 12996: Unable to Resize Volume (kvm, vmware)
From: "Devdeep Singh" <devdeep.singh@citrix.com>
To: "Ram Ganesh" <ram.ganesh@citrix.com>, "edison su" <edison.su@citrix.com>,
 "Min Chen" <min.chen@citrix.com>, "Devdeep Singh" <devdeep.singh@citrix.com>
Cc: "Rajesh Battala" <rajesh.battala@citrix.com>,
 "cloudstack" <cloudstack-dev@incubator.apache.org>
Date: Mon, 29 Jul 2013 13:26:50 -0000
Message-ID: <20130729132650.30961.12600@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Devdeep Singh" <noreply@reviews.apache.org>
References: <20130727150549.537.56046@reviews.apache.org>
In-Reply-To: <20130727150549.537.56046@reviews.apache.org>
Reply-To: "Devdeep Singh" <devdeep.singh@citrix.com>

--===============6041562181421637721==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12996/#review24118
-----------------------------------------------------------

Ship it!


Committed to 4.2 and master. Kindly close the request.

- Devdeep Singh


On July 27, 2013, 3:05 p.m., Rajesh Battala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12996/
> -----------------------------------------------------------
> 
> (Updated July 27, 2013, 3:05 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, edison su, Min Chen, and Ram Ganesh.
> 
> 
> Bugs: 3877
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Issue:
> =====
> this issue is with the way we extract the hypevisor type from the sql 
> 
> 
> mysql> SELECT s.hypervisor, c.hypervisor_type from volumes v, storage_pool s, cluster c where v.pool_id = s.id and s.cluster_id = c.id and v.id = 21;
> +------------+-----------------+
> | hypervisor | hypervisor_type |
> +------------+-----------------+
> | NULL | KVM |
> +------------+-----------------+
> 
> 
> first column value will be not null if the storage pool is Zone wide else it will be NULL. 
> but in the code always first column is considering to figure out the hypervisor type which causing the hpervisor type to be NONE and hence failing to resize the volume
> 
> 
> this issue is happening while determining the hypervisor type for a volume. 
> for ZWPS, it will return the hypervisor because, in storage pool we store the hypervisor type if the pool is added of scoe ZONE. 
> if the pool is of scope Cluster hypervisor type will be NULL
> 
> we support volume resize when the volume is present on ZONE scope and Cluster scope. 
> they way of hypervisor type extraction from the sql query result should be change which will resolve this blocker.
> 
> 
> Fix:
> =====
> 
> depending on the scope type of storage pool, the sql result is passed to determined the hypervisor type.
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java 7696bcc 
> 
> Diff: https://reviews.apache.org/r/12996/diff/
> 
> 
> Testing
> -------
> 
> 1. Able to resize the volume successfully
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>


--===============6041562181421637721==--