Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F3F57C64C for ; Mon, 29 Jul 2013 08:42:47 +0000 (UTC) Received: (qmail 47627 invoked by uid 500); 29 Jul 2013 08:42:47 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 47578 invoked by uid 500); 29 Jul 2013 08:42:47 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 47569 invoked by uid 500); 29 Jul 2013 08:42:46 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 47563 invoked by uid 99); 29 Jul 2013 08:42:46 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Jul 2013 08:42:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 731621D0E66; Mon, 29 Jul 2013 08:42:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3614955168777263656==" MIME-Version: 1.0 Subject: Re: Review Request 12937: CLOUDSTACK-3779: Support System vm scaling on VMWare From: "ASF Subversion and Git Services" To: "Nitin Mehta" Cc: "cloudstack" , "Harikrishna Patnala" , "ASF Subversion and Git Services" Date: Mon, 29 Jul 2013 08:42:45 -0000 Message-ID: <20130729084245.30929.38972@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "ASF Subversion and Git Services" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/12937/ X-Sender: "ASF Subversion and Git Services" References: <20130726084103.32008.31065@reviews.apache.org> In-Reply-To: <20130726084103.32008.31065@reviews.apache.org> Reply-To: "ASF Subversion and Git Services" --===============3614955168777263656== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12937/#review24100 ----------------------------------------------------------- Commit 4d35d92208c9b63ca27c794508d4c534fa773078 in branch refs/heads/4.2 from Harikrishna Patnala [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4d35d92 ] CLOUDSTACK-3779: Support System vm scaling on VMWare Marked the system template new system template as dynamicallyScalable - handled upgrade case - moved "dynamicallyScalable" flag to vm_instance table from user_vm_details to support dynamic scaling of system vm Signed off by : Nitin Mehta - ASF Subversion and Git Services On July 26, 2013, 8:41 a.m., Harikrishna Patnala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12937/ > ----------------------------------------------------------- > > (Updated July 26, 2013, 8:41 a.m.) > > > Review request for cloudstack and Nitin Mehta. > > > Bugs: CLOUDSTACK-3637 and CLOUDSTACK-3779 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-3779: Support System vm scaling on VMWare > > Marked the system template new system template as dynamicallyScalable > - handled upgrade case > - moved "dynamicallyScalable" flag to vm_instance table from user_vm_details to support dynamic scaling of system vm > > This patch depends on previous review request https://reviews.apache.org/r/12759/ . please review and commit accordingly > > > Diffs > ----- > > engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java d4b7b6d > engine/schema/src/com/cloud/vm/VMInstanceVO.java e1d2892 > engine/schema/src/com/cloud/vm/dao/UserVmDao.java b4f9991 > engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java 1c11563 > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 2cc592d > server/src/com/cloud/hypervisor/HypervisorGuruBase.java 6d368bd > server/src/com/cloud/server/ManagementServerImpl.java 7ac1254 > server/src/com/cloud/vm/UserVmManagerImpl.java ae12523 > server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44a703d > setup/db/db/schema-410to420.sql 82ca403 > > Diff: https://reviews.apache.org/r/12937/diff/ > > > Testing > ------- > > > Thanks, > > Harikrishna Patnala > > --===============3614955168777263656==--