Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============1353156466265721622=="
MIME-Version: 1.0
Subject: Re: Review Request 13009: CLOUDSTACK-3744 - Accounts not cleaned up
From: "Sowmya Krishnan" <sowmya.krishnan@citrix.com>
To: "Prasanna Santhanam" <tsp@apache.org>
Cc: "cloudstack" <cloudstack-dev@incubator.apache.org>,
 "Sowmya Krishnan" <sowmya.krishnan@citrix.com>
Date: Mon, 29 Jul 2013 05:12:25 -0000
Message-ID: <20130729051225.30929.53915@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Sowmya Krishnan" <noreply@reviews.apache.org>
References: <20130729043532.30929.77487@reviews.apache.org>
In-Reply-To: <20130729043532.30929.77487@reviews.apache.org>
Reply-To: "Sowmya Krishnan" <sowmya.krishnan@citrix.com>

--===============1353156466265721622==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


> On July 29, 2013, 4:35 a.m., Prasanna Santhanam wrote:
> > test/integration/component/test_netscaler_nw_off.py, line 613
> > <https://reviews.apache.org/r/13009/diff/1/?file=330048#file330048line613>
> >
> >     I think you should remove the ntwk offering altogether from cleanup. 
> >     
> >     Network offerings currently do not delete if the account's network deployed from that offering isn't shutdown in time. Since offerings are lightweight and do not consume physical/virtual resources, we should defer them from the cleanup process.
> 
> Sowmya Krishnan wrote:
>     Reason to wait on cleanup in this test is to remove the Netscaler devices added as part of the test. Those could be used for other tests. To remove the device, we need to wait on clean up of the networks as well. So we aren't really waiting on network offering cleanup.

Although, i could still remove the offering cleanup too... Will do that.


- Sowmya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13009/#review24082
-----------------------------------------------------------


On July 29, 2013, 4:12 a.m., Sowmya Krishnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13009/
> -----------------------------------------------------------
> 
> (Updated July 29, 2013, 4:12 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3744
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fix for CLOUDSTACK-3744. Order of cleanup of objects fixed.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_netscaler_nw_off.py 5fd2195 
> 
> Diff: https://reviews.apache.org/r/13009/diff/
> 
> 
> Testing
> -------
> 
> Tested locally. Script is now passing and cleanup of all accounts done.
> 
> 
> Thanks,
> 
> Sowmya Krishnan
> 
>


--===============1353156466265721622==--