Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C45581082E for ; Sun, 28 Jul 2013 11:06:34 +0000 (UTC) Received: (qmail 5191 invoked by uid 500); 28 Jul 2013 11:06:31 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 5117 invoked by uid 500); 28 Jul 2013 11:06:29 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 5106 invoked by uid 500); 28 Jul 2013 11:06:27 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 5099 invoked by uid 99); 28 Jul 2013 11:06:26 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 28 Jul 2013 11:06:26 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F37BE1C0054; Sun, 28 Jul 2013 11:06:24 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4718342642705293490==" MIME-Version: 1.0 Subject: Re: Review Request 12913: Fix map based APIs in CloudMonkey From: "Rohit Yadav" To: "Rohit Yadav" Cc: "cloudstack" , "Carson Anderson" Date: Sun, 28 Jul 2013 11:06:24 -0000 Message-ID: <20130728110624.30929.13804@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Rohit Yadav" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/12913/ X-Sender: "Rohit Yadav" References: <20130725045257.32008.3723@reviews.apache.org> In-Reply-To: <20130725045257.32008.3723@reviews.apache.org> Reply-To: "Rohit Yadav" --===============4718342642705293490== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12913/#review24057 ----------------------------------------------------------- Thanks, it was applied on the new cloudmonkey/master repo; commit 924554fa2507818b7d77144c70e6bf5387b33175 Author: Carson Anderson AuthorDate: Thu Jul 25 15:50:14 2013 -0600 Commit: Rohit Yadav CommitDate: Sun Jul 28 16:15:20 2013 +0530 - Rohit Yadav On July 25, 2013, 4:52 a.m., Carson Anderson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12913/ > ----------------------------------------------------------- > > (Updated July 25, 2013, 4:52 a.m.) > > > Review request for cloudstack and Rohit Yadav. > > > Bugs: CLOUDSTACK-3787 > > > Repository: cloudstack-git > > > Description > ------- > > CM does not detect required tags if they are passed as a map. When creating resource tags for example. The tags[0].key and tags[0].value weren't counted for the "tags" parameter and CM would give a "missing required parameter" error. > > > Diffs > ----- > > tools/cli/cloudmonkey/cloudmonkey.py 13f54ad > > Diff: https://reviews.apache.org/r/12913/diff/ > > > Testing > ------- > > Tested by adding/removing resourceTags > > > Thanks, > > Carson Anderson > > --===============4718342642705293490==--