Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============1782777378464654980=="
MIME-Version: 1.0
Subject: Review Request 12996: Unable to Resize Volume (kvm, vmware)
From: "Rajesh Battala" <rajesh.battala@citrix.com>
To: "Ram Ganesh" <ram.ganesh@citrix.com>, "edison su" <edison.su@citrix.com>,
 "Min Chen" <min.chen@citrix.com>, "Devdeep Singh" <devdeep.singh@citrix.com>
Cc: "Rajesh Battala" <rajesh.battala@citrix.com>,
 "cloudstack" <cloudstack-dev@incubator.apache.org>
Date: Sat, 27 Jul 2013 15:05:49 -0000
Message-ID: <20130727150549.537.56046@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Rajesh Battala" <noreply@reviews.apache.org>
Reply-To: "Rajesh Battala" <rajesh.battala@citrix.com>

--===============1782777378464654980==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12996/
-----------------------------------------------------------

Review request for cloudstack, Devdeep Singh, edison su, Min Chen, and Ram Ganesh.


Bugs: 3877


Repository: cloudstack-git


Description
-------

Issue:
=====
this issue is with the way we extract the hypevisor type from the sql 


mysql> SELECT s.hypervisor, c.hypervisor_type from volumes v, storage_pool s, cluster c where v.pool_id = s.id and s.cluster_id = c.id and v.id = 21;
+------------+-----------------+
| hypervisor | hypervisor_type |
+------------+-----------------+
| NULL | KVM |
+------------+-----------------+


first column value will be not null if the storage pool is Zone wide else it will be NULL. 
but in the code always first column is considering to figure out the hypervisor type which causing the hpervisor type to be NONE and hence failing to resize the volume


this issue is happening while determining the hypervisor type for a volume. 
for ZWPS, it will return the hypervisor because, in storage pool we store the hypervisor type if the pool is added of scoe ZONE. 
if the pool is of scope Cluster hypervisor type will be NULL

we support volume resize when the volume is present on ZONE scope and Cluster scope. 
they way of hypervisor type extraction from the sql query result should be change which will resolve this blocker.


Fix:
=====

depending on the scope type of storage pool, the sql result is passed to determined the hypervisor type.


Diffs
-----

  engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java 7696bcc 

Diff: https://reviews.apache.org/r/12996/diff/


Testing
-------

1. Able to resize the volume successfully


Thanks,

Rajesh Battala


--===============1782777378464654980==--