Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============3484710418043814716=="
MIME-Version: 1.0
Subject: Re: Review Request 12985: CLOUDSTACK-3682: NPE in BridgeVifDriver
 causing
 systemvm startup failure in KVM
From: "Jenkins Cloudstack.org" <hugo@apache.org>
To: "Hugo Trippaers" <htrippaers@schubergphilis.com>,
 "Sheng Yang" <sheng@yasker.org>, "Chiradeep Vittal" <chiradeepv@gmail.com>,
 "Alena Prokharchyk" <alena.prokharchyk@citrix.com>,
 "Murali Reddy" <muralimmreddy@gmail.com>
Cc: "cloudstack" <cloudstack-dev@incubator.apache.org>,
 "Jenkins Cloudstack.org" <hugo@apache.org>,
 "Toshiaki Hatano" <toshiaki.hatano@verio.net>
Date: Sat, 27 Jul 2013 01:13:12 -0000
Message-ID: <20130727011312.32008.20636@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Jenkins Cloudstack.org" <noreply@reviews.apache.org>
References: <20130727002552.32008.95220@reviews.apache.org>
In-Reply-To: <20130727002552.32008.95220@reviews.apache.org>
Reply-To: "Jenkins Cloudstack.org" <hugo@apache.org>

--===============3484710418043814716==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12985/#review24003
-----------------------------------------------------------


Review 12985 PASSED the build test
The url of build cloudstack-master-with-patch #57 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/57/

- Jenkins Cloudstack.org


On July 27, 2013, 12:25 a.m., Toshiaki Hatano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12985/
> -----------------------------------------------------------
> 
> (Updated July 27, 2013, 12:25 a.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk, Chiradeep Vittal, Murali Reddy, Hugo Trippaers, and Sheng Yang.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3682
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CloudStack-management suddenly start generating broadcastUri in 'vlan:XXXX' style instead of 'vlan://XXXX' style.
> That cause issue in KVM-agent VifDrivers (both Bridge and OVS), since they cannot purse different style Uri.
> 
> For the compatibility to older version, CloudStack-management should generate 'vlan://XXXX' style BroadcastUri.
> 
> Change the URI creation way in 2 method below to make sure they generate 'scheme://host' style BroadcastUri.
>     - com.cloud.network.Networks.IsolationType.toUri(T)
>     - com.cloud.network.Networks.BroadcastDomainType.toUri(T)
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/network/Networks.java c76c3d4 
>   plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java 195cf40 
>   plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java 7038d7e 
>   server/src/com/cloud/network/guru/PublicNetworkGuru.java 8beb42e 
> 
> Diff: https://reviews.apache.org/r/12985/diff/
> 
> 
> Testing
> -------
> 
> Tested locally, advanced zone with a KVM hypervisor. 
> 
> 
> Thanks,
> 
> Toshiaki Hatano
> 
>


--===============3484710418043814716==--