Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A37B7C530 for ; Fri, 26 Jul 2013 18:48:27 +0000 (UTC) Received: (qmail 28644 invoked by uid 500); 26 Jul 2013 18:48:27 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 28432 invoked by uid 500); 26 Jul 2013 18:48:26 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 28418 invoked by uid 500); 26 Jul 2013 18:48:26 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 28410 invoked by uid 99); 26 Jul 2013 18:48:25 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Jul 2013 18:48:25 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D70EE1D0979; Fri, 26 Jul 2013 18:48:24 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2792138605328259549==" MIME-Version: 1.0 Subject: Re: Review Request 12958: Automation test failure: can't attach volume to a stopped created VM. Fix the null pointer From: "Fang Wang" To: "edison su" Cc: "cloudstack" , "Jenkins Cloudstack.org" , "Fang Wang" Date: Fri, 26 Jul 2013 18:48:24 -0000 Message-ID: <20130726184824.32328.41408@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Fang Wang" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/12958/ X-Sender: "Fang Wang" References: <20130726000311.32008.14475@reviews.apache.org> In-Reply-To: <20130726000311.32008.14475@reviews.apache.org> Reply-To: "Fang Wang" --===============2792138605328259549== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On July 26, 2013, 12:03 a.m., Jenkins Cloudstack.org wrote: > > Review 12958 failed the build test : FAILURE > > The url of build cloudstack-master-with-patch #41 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/41/ I did not check into master. Not sure which patch this 41 is? I tested and built my code on 4.2 branch. - Fang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12958/#review23895 ----------------------------------------------------------- On July 25, 2013, 11:15 p.m., Fang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12958/ > ----------------------------------------------------------- > > (Updated July 25, 2013, 11:15 p.m.) > > > Review request for cloudstack and edison su. > > > Bugs: CLOUDSTACK-3759 > > > Repository: cloudstack-git > > > Description > ------- > > When the new VM is created and put in stopped state, the volume and pool is not allocated. Hence the NPE. > > > Diffs > ----- > > server/src/com/cloud/storage/VolumeManagerImpl.java d7d62b0 > > Diff: https://reviews.apache.org/r/12958/diff/ > > > Testing > ------- > > > Thanks, > > Fang Wang > > --===============2792138605328259549==--