Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============6200146871172925683=="
MIME-Version: 1.0
Subject: Re: Review Request 12808: Fix for CLOUDSTACK-2536: updating
 parameters
 (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are
 redundant(cluster level)
From: "ASF Subversion and Git Services" <asfbot@urd.zones.apache.org>
To: "Koushik Das" <koushik.das@citrix.com>,
 "Nitin Mehta" <nitin.mehta@citrix.com>
Cc: "cloudstack" <cloudstack-dev@incubator.apache.org>,
 "ASF Subversion and Git Services" <asfbot@urd.zones.apache.org>,
 "Harikrishna Patnala" <harikrishna.patnala@citrix.com>
Date: Thu, 25 Jul 2013 08:27:43 -0000
Message-ID: <20130725082743.32328.61599@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "ASF Subversion and Git Services" <noreply@reviews.apache.org>
References: <20130725071928.32008.10259@reviews.apache.org>
In-Reply-To: <20130725071928.32008.10259@reviews.apache.org>
Reply-To: "ASF Subversion and Git Services" <asfbot@urd.zones.apache.org>

--===============6200146871172925683==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12808/#review23824
-----------------------------------------------------------


Commit 4c81ea69c4e8326cc81a0e2607f6a6d99645ce5f in branch refs/heads/4.2 from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4c81ea6 ]

Fix for CLOUDSTACK-2536

Removing memoryovercommitratio and cpuovercommitratio parameters from addCluster and updateCluster APIs,
since these can be configurable using updateConfiguration API at cluster level.
By default while creating cluster these values are taken from global configuration parameters.

Conflicts:
	server/src/com/cloud/resource/ResourceManagerImpl.java


- ASF Subversion and Git Services


On July 25, 2013, 7:19 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12808/
> -----------------------------------------------------------
> 
> (Updated July 25, 2013, 7:19 a.m.)
> 
> 
> Review request for cloudstack, Koushik Das and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-1528 and CLOUDSTACK-2536
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-2536:  updating parameters (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are redundant(cluster level) 
> There are two APIs updateCluster and UpdateConfiguration where we can update these parameters. Ideally this should get updated using updateConfiguration API, so removing from updateCluster API
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/resource/ResourceService.java 25298cc 
>   api/src/org/apache/cloudstack/api/ApiConstants.java 0550a39 
>   api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java c6ca9bc6 
>   api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java a14f905 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 9bc8efd 
>   server/src/com/cloud/resource/ResourceManagerImpl.java 342b9fd 
>   server/test/com/cloud/resource/MockResourceManagerImpl.java 2c66134 
> 
> Diff: https://reviews.apache.org/r/12808/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


--===============6200146871172925683==--