Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============0412063774402666929=="
MIME-Version: 1.0
Subject: Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in
 bash
 script
From: "Sheng Yang" <sheng@yasker.org>
To: "Alena Prokharchyk" <alena.prokharchyk@citrix.com>,
 "Sheng Yang" <sheng@yasker.org>
Cc: "cloudstack" <cloudstack-dev@incubator.apache.org>,
 "bharat kumar" <bharat.kumar@citrix.com>
Date: Tue, 23 Jul 2013 20:51:35 -0000
Message-ID: <20130723205135.21527.57238@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Sheng Yang" <noreply@reviews.apache.org>
References: <20130723130742.4985.54265@reviews.apache.org>
In-Reply-To: <20130723130742.4985.54265@reviews.apache.org>
Reply-To: "Sheng Yang" <sheng@yasker.org>

--===============0412063774402666929==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12810/#review23713
-----------------------------------------------------------


patches/systemvm/debian/config/root/dnsmasq.sh
<https://reviews.apache.org/r/12810/#comment47591>

    dns2 can be null.


patches/systemvm/debian/config/root/dnsmasq.sh
<https://reviews.apache.org/r/12810/#comment47592>

    dhcp-option=tag.* is not in the log


patches/systemvm/debian/config/root/dnsmasq.sh
<https://reviews.apache.org/r/12810/#comment47594>

    Backup the failure configures would also help to investigate in the future.


patches/systemvm/debian/config/root/dnsmasq.sh
<https://reviews.apache.org/r/12810/#comment47593>

    No, don't override the original result. It failed, then we need to fail loudly. The overriding here would cover the fact that it's failed to apply the new config.


It's in much better shape than previous edition. Please do more testing, e.g. VPC, multiple guest network for user VM. It's likely we can get it in tomorrow.

Thanks!

- Sheng Yang


On July 23, 2013, 1:07 p.m., bharat kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12810/
> -----------------------------------------------------------
> 
> (Updated July 23, 2013, 1:07 p.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk and Sheng Yang.
> 
> 
> Bugs: CLOUDSTACK-3694
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-3694
> 
> wrote the dnsmasq config in bash instead of creating the config file in java and overwriting. 
> 
> 
> Diffs
> -----
> 
>   core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java 521ad70 
>   core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 0b26220 
>   core/src/com/cloud/network/DnsMasqConfigurator.java 3fc61df 
>   patches/systemvm/debian/config/etc/init.d/cloud-early-config c04ff90 
>   patches/systemvm/debian/config/root/dnsmasq.sh b70e2d3 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java c7f487e 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java f80d4b6 
>   scripts/vm/hypervisor/xenserver/vmops f8c0253 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 6c0f7a1 
> 
> Diff: https://reviews.apache.org/r/12810/diff/
> 
> 
> Testing
> -------
> 
> Tested on old master using xenserver.
>  Could not test on the latest one as it is broken.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>


--===============0412063774402666929==--