Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4251D10EFB for ; Mon, 22 Jul 2013 14:03:58 +0000 (UTC) Received: (qmail 1570 invoked by uid 500); 22 Jul 2013 14:03:57 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 1421 invoked by uid 500); 22 Jul 2013 14:03:57 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 1327 invoked by uid 500); 22 Jul 2013 14:03:56 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 1046 invoked by uid 99); 22 Jul 2013 14:03:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Jul 2013 14:03:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EDCDD1CFC5F; Mon, 22 Jul 2013 14:03:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6847163208714712089==" MIME-Version: 1.0 Subject: Re: Review Request 12812: CLOUDSTACK-3610: Fix regression test "test_accounts.TestUserLogin" From: "Prasanna Santhanam" To: "Prasanna Santhanam" , "Parth Jagirdar" Cc: "Girish Shilamkar" , "cloudstack" Date: Mon, 22 Jul 2013 14:03:54 -0000 Message-ID: <20130722140354.4985.14527@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Prasanna Santhanam" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/12812/ X-Sender: "Prasanna Santhanam" References: <20130722135242.4985.51680@reviews.apache.org> In-Reply-To: <20130722135242.4985.51680@reviews.apache.org> Reply-To: "Prasanna Santhanam" --===============6847163208714712089== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12812/#review23630 ----------------------------------------------------------- Ship it! Ship It! - Prasanna Santhanam On July 22, 2013, 1:52 p.m., Girish Shilamkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12812/ > ----------------------------------------------------------- > > (Updated July 22, 2013, 1:52 p.m.) > > > Review request for cloudstack, Parth Jagirdar and Prasanna Santhanam. > > > Bugs: CLOUDSTACK-3610 > > > Repository: cloudstack-git > > > Description > ------- > > Now password is sent as clear text as per CLOUDSTACK-1734. So changed marvin to handle this. Plus domainid was not passed in the testcase and marvin used "domainid" instead of "domainId" as a parameter. Fixed these two errors. > > > Diffs > ----- > > test/integration/component/test_accounts.py 65c0c6f > tools/marvin/marvin/integration/lib/base.py bc8c603 > > Diff: https://reviews.apache.org/r/12812/diff/ > > > Testing > ------- > > > Thanks, > > Girish Shilamkar > > --===============6847163208714712089==--