Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AAF6A10CB5 for ; Mon, 22 Jul 2013 12:54:35 +0000 (UTC) Received: (qmail 73917 invoked by uid 500); 22 Jul 2013 12:54:35 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 73837 invoked by uid 500); 22 Jul 2013 12:54:35 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 73829 invoked by uid 500); 22 Jul 2013 12:54:35 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 73823 invoked by uid 99); 22 Jul 2013 12:54:35 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Jul 2013 12:54:35 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5192B1CFC5F; Mon, 22 Jul 2013 12:54:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6863495929605688039==" MIME-Version: 1.0 Subject: Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script From: "bharat kumar" To: "Alena Prokharchyk" , "Sheng Yang" Cc: "cloudstack" , "bharat kumar" Date: Mon, 22 Jul 2013 12:54:34 -0000 Message-ID: <20130722125434.4985.44421@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "bharat kumar" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/12810/ X-Sender: "bharat kumar" References: <20130722125058.4976.28809@reviews.apache.org> In-Reply-To: <20130722125058.4976.28809@reviews.apache.org> Reply-To: "bharat kumar" --===============6863495929605688039== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/ ----------------------------------------------------------- (Updated July 22, 2013, 12:54 p.m.) Review request for cloudstack, Alena Prokharchyk and Sheng Yang. Changes ------- Removed set -x from dnsmasq.sh Bugs: CLOUDSTACK-3694 Repository: cloudstack-git Description ------- https://issues.apache.org/jira/browse/CLOUDSTACK-3694 wrote the dnsmasq config in bash instead of creating the config file in java and overwriting. Diffs (updated) ----- core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java 521ad70 core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 0b26220 core/src/com/cloud/network/DnsMasqConfigurator.java 3fc61df patches/systemvm/debian/config/root/createIpAlias.sh 5498195 patches/systemvm/debian/config/root/dnsmasq.sh b70e2d3 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java c7f487e plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java f80d4b6 scripts/vm/hypervisor/xenserver/vmops f8c0253 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 6c0f7a1 Diff: https://reviews.apache.org/r/12810/diff/ Testing ------- Tested on old master using xenserver. Could not test on the latest one as it is broken. Thanks, bharat kumar --===============6863495929605688039==--