Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============0947655053924597199=="
MIME-Version: 1.0
Subject: Re: Review Request 12752: Async commands can inject the job id
From: "Ryan Dietrich" <ryan@betterservers.com>
To: "Marcus Sorensen" <shadowsor@gmail.com>
Cc: "cloudstack" <cloudstack-dev@incubator.apache.org>,
 "Ryan Dietrich" <ryan@betterservers.com>
Date: Fri, 19 Jul 2013 17:54:53 -0000
Message-ID: <20130719175453.12001.70752@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Ryan Dietrich" <noreply@reviews.apache.org>
References: <20130718232816.1153.51124@reviews.apache.org>
In-Reply-To: <20130718232816.1153.51124@reviews.apache.org>
Reply-To: "Ryan Dietrich" <ryan@betterservers.com>

--===============0947655053924597199==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12752/
-----------------------------------------------------------

(Updated July 19, 2013, 5:54 p.m.)


Review request for cloudstack and Marcus Sorensen.


Changes
-------

Thanks for the code change mod Marcus!  (changed the length call to the regex, I verified in the database this was the exact format being used)


Repository: cloudstack-git


Description
-------

I added "injectedjobid" to the BaseAsyncCmd class as a parameter.
If set, it will allow you to tell Cloudstack what the job id instead of it choosing one.
A basic string length test is done to verify the variable passed in is actually a UUID.
If it is not valid, it is ignored and the job generates it's own.


Diffs (updated)
-----

  api/src/org/apache/cloudstack/api/BaseAsyncCmd.java 0e6f95d 
  server/src/com/cloud/api/ApiServer.java 95f17af 
  server/src/com/cloud/async/AsyncJobVO.java 41eccb4 
  test/integration/smoke/test_deploy_vm.py 425aeb7 
  tools/marvin/marvin/codegenerator.py 632b8c6 
  tools/marvin/marvin/integration/lib/base.py 161d03c 

Diff: https://reviews.apache.org/r/12752/diff/


Testing
-------

Updated marvin, updated the deploy vm test.  Ran multiple async commands manually, with and without injectedjobid present, no issues detected.


Thanks,

Ryan Dietrich


--===============0947655053924597199==--