Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 19CB6108BA for ; Wed, 17 Jul 2013 23:54:42 +0000 (UTC) Received: (qmail 86865 invoked by uid 500); 17 Jul 2013 23:54:41 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 86823 invoked by uid 500); 17 Jul 2013 23:54:41 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 86812 invoked by uid 500); 17 Jul 2013 23:54:41 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 86801 invoked by uid 99); 17 Jul 2013 23:54:41 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Jul 2013 23:54:41 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6B20D1CA746; Wed, 17 Jul 2013 23:54:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0214031801463937411==" MIME-Version: 1.0 Subject: Re: Review Request 12612: Fix NPE when attaching vmware-tools iso to guest VM on ESX From: "Venkata Siva Vijayendra Bhamidipati" To: "Sateesh Chodapuneedi" , "edison su" , "Chip Childers" , "Kelven Yang" , "Sheng Yang" Cc: "Venkata Siva Vijayendra Bhamidipati" , "cloudstack" , "Min Chen" Date: Wed, 17 Jul 2013 23:54:41 -0000 Message-ID: <20130717235441.1153.79303@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Venkata Siva Vijayendra Bhamidipati" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/12612/ X-Sender: "Venkata Siva Vijayendra Bhamidipati" References: <20130717003904.1154.38230@reviews.apache.org> In-Reply-To: <20130717003904.1154.38230@reviews.apache.org> Reply-To: "Venkata Siva Vijayendra Bhamidipati" --===============0214031801463937411== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12612/ ----------------------------------------------------------- (Updated July 17, 2013, 11:54 p.m.) Review request for cloudstack, Chip Childers, edison su, Kelven Yang, Sateesh Chodapuneedi, and Sheng Yang. Changes ------- Incorporating Min's/Sheng's comments. Bugs: CLOUDSTACK-3554 Repository: cloudstack-git Description ------- Fixing NPE that occurs when attaching vmware-tools.iso to a guest VM on ESX. Diffs (updated) ----- plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java 4113803 Diff: https://reviews.apache.org/r/12612/diff/ Testing ------- With the fix in place, vmware-tools.iso attach to a vmware guest VM works as expected. Thanks, Venkata Siva Vijayendra Bhamidipati --===============0214031801463937411==--