Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============0899906431853481505=="
MIME-Version: 1.0
Subject: Re: Review Request 12273: Cloudstack-2150 DB table entries of
 phisical
 network is not proper.Shows Duplicate entries Cloudstack-2980 Adding a VLAN
 range that overlaps with two existing ranges results inconsistent DB entries
From: "Abhinandan Prateek" <aprateek@apache.org>
To: "Abhinandan Prateek" <aprateek@apache.org>
Cc: "cloudstack" <cloudstack-dev@incubator.apache.org>,
 "bharat kumar" <bharat.kumar@citrix.com>
Date: Wed, 17 Jul 2013 03:32:56 -0000
Message-ID: <20130717033256.1154.36903@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Abhinandan Prateek" <noreply@reviews.apache.org>
References: <20130710174307.14335.77239@reviews.apache.org>
In-Reply-To: <20130710174307.14335.77239@reviews.apache.org>
Reply-To: "Abhinandan Prateek" <aprateek@apache.org>

--===============0899906431853481505==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12273/#review23235
-----------------------------------------------------------

Ship it!


Ship It!

- Abhinandan Prateek


On July 10, 2013, 5:43 p.m., bharat kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12273/
> -----------------------------------------------------------
> 
> (Updated July 10, 2013, 5:43 p.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: Cloudstack-2150 and Cloudstack-2980
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Cloudstack-2150 DB table entries of phisical network is not proper.Shows Duplicate entries Cloudstack-2980 Adding a
> VLAN range that overlaps with two existing ranges results inconsistent DB entries
> This fix was causing a regression due to which the state of the physical network was not getting updated and as a result basic zone deployment failed. Resubmitting the fixed code.
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/dc/dao/DataCenterDao.java ed6e696 
>   engine/schema/src/com/cloud/dc/dao/DataCenterDaoImpl.java 503306f 
>   engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java 778498d 
>   engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java e97f2c6 
>   server/src/com/cloud/network/NetworkServiceImpl.java 49bfb88 
>   server/test/com/cloud/network/UpdatePhysicalNetworkTest.java 25c023e 
> 
> Diff: https://reviews.apache.org/r/12273/diff/
> 
> 
> Testing
> -------
> 
> Tested 
> basic zone deployment.
> adding vlan
> removing vlan
> removing all vlan
> checked if all the added vlans are in the db.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>


--===============0899906431853481505==--