Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============7401967650080205675=="
MIME-Version: 1.0
Subject: Review Request 12510: CLOUDSTACK 3476 : deleteDomain api should fail
 when
 release dedicated resource to that domain fails:
From: "Saksham Srivastava" <saksham.srivastava@citrix.com>
To: "Devdeep Singh" <devdeep.singh@citrix.com>,
 "Alena Prokharchyk" <alena.prokharchyk@citrix.com>
Cc: "Saksham Srivastava" <saksham.srivastava@citrix.com>,
 "cloudstack" <cloudstack-dev@incubator.apache.org>
Date: Fri, 12 Jul 2013 14:01:05 -0000
Message-ID: <20130712140105.14335.20516@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Saksham Srivastava" <noreply@reviews.apache.org>
Reply-To: "Saksham Srivastava" <saksham.srivastava@citrix.com>

--===============7401967650080205675==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12510/
-----------------------------------------------------------

Review request for cloudstack, Alena Prokharchyk and Devdeep Singh.


Bugs: 3476


Repository: cloudstack-git


Description
-------

In case the release dedicate resource fails, deletion of domain should not happen. 
Whenever deleting a domain all the resources dedicated to it must be released of dedication and moved to shared pool. 
Currently even if release API fails the deleteDomain API is executed successfully. 

Further if there are dedicated resources to a domiain and cleanup is not true, resources should not be released.
Added checks to prohibit this behaviour.


Diffs
-----

  server/src/com/cloud/user/DomainManagerImpl.java aad5787 

Diff: https://reviews.apache.org/r/12510/diff/


Testing
-------

If domain has dedicated resources, cleanup=true will release dedication and delete the domain.
cleanup=false will not release dedication and will not delete the domain.


Thanks,

Saksham Srivastava


--===============7401967650080205675==--